-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic bunker can now activate automatically if enough ahelps have occured #33289
base: master
Are you sure you want to change the base?
Panic bunker can now activate automatically if enough ahelps have occured #33289
Conversation
Is this counting individual messages or seperate users using Ahelp? One person can pretty rapidly hit the lower bound (6?) if they're doing multiple posts in the relay. |
I don't know the correct terminology but its counting the amount of ahelp "threads" that are open. E.g if 2 players both open ahelps and both had like 20 messages including admin responses, the count I'm looking at would be 2 not 40+. |
Got it. In that case, I think the sub 10 minute panic should be set to 4, since usually when something like a raider is found out, it's going to be 3 or 4 people ahelping, but that shouldn't cause it to trigger when an antag gets caught by sec and complains. Otherwise I think the overall panic value is good. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the PR
Added three CCVars that allow the panic bunker to be automatically enabled if enough ahelps have occurred.
1.) If
activate_panic_bunker_received_ahelps_time
have occurred in a round, the bunker is enabled.2.) If
activate_panic_bunker_received_ahelps_amount
ahelps have occured in the lastactivate_panic_bunker_received_ahelps_time
minutes, the bunker is enabled.Both will also check for the
disable_with_admins
CCVar and wont activate if its true and there is an admin online. They will also only ever activate once per round.Why / Balance
Resolves #23031!
Technical details
This stuff is kind of out of my depth in multiple ways 😆
1.) I'm not sure this is the correct location for the CCVars (Should they be in admin or panic bunker?)
2.) The default numbers are literally pulled from thin air. I have ZERO idea what would even be close to making sense! If an admin could chime in and give defaults I'd appreciate it!
3.) I'm not sure this is the correct location for the function either! Should I make a new panic bunker system?
Requirements
Breaking changes
Changelog
🆑 Beck Thompson
ADMIN: