Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic bunker can now activate automatically if enough ahelps have occured #33289

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

beck-thompson
Copy link
Contributor

About the PR

Added three CCVars that allow the panic bunker to be automatically enabled if enough ahelps have occurred.
1.) If activate_panic_bunker_received_ahelps_time have occurred in a round, the bunker is enabled.
2.) If activate_panic_bunker_received_ahelps_amount ahelps have occured in the last activate_panic_bunker_received_ahelps_time minutes, the bunker is enabled.

Both will also check for the disable_with_admins CCVar and wont activate if its true and there is an admin online. They will also only ever activate once per round.

Why / Balance

Resolves #23031!

Technical details

This stuff is kind of out of my depth in multiple ways 😆
1.) I'm not sure this is the correct location for the CCVars (Should they be in admin or panic bunker?)
2.) The default numbers are literally pulled from thin air. I have ZERO idea what would even be close to making sense! If an admin could chime in and give defaults I'd appreciate it!
3.) I'm not sure this is the correct location for the function either! Should I make a new panic bunker system?

Requirements

Breaking changes

Changelog

🆑 Beck Thompson
ADMIN:

  • add: Panic bunker is automatically enabled if enough ahelps have occurred in a round or a certain amount of time. This can be changed in a CCVar.

@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Nov 13, 2024
@Admiral-Obvious-001
Copy link
Contributor

Admiral-Obvious-001 commented Nov 13, 2024

Is this counting individual messages or seperate users using Ahelp? One person can pretty rapidly hit the lower bound (6?) if they're doing multiple posts in the relay.

@beck-thompson
Copy link
Contributor Author

Is this counting individual messages or seperate users using Ahelp? One person can pretty rapidly hit the lower bound (6?) if they're doing multiple posts in the relay.

I don't know the correct terminology but its counting the amount of ahelp "threads" that are open. E.g if 2 players both open ahelps and both had like 20 messages including admin responses, the count I'm looking at would be 2 not 40+.

@Admiral-Obvious-001
Copy link
Contributor

Admiral-Obvious-001 commented Nov 13, 2024

Is this counting individual messages or seperate users using Ahelp? One person can pretty rapidly hit the lower bound (6?) if they're doing multiple posts in the relay.

I don't know the correct terminology but its counting the amount of ahelp "threads" that are open. E.g if 2 players both open ahelps and both had like 20 messages including admin responses, the count I'm looking at would be 2 not 40+.

Got it.

In that case, I think the sub 10 minute panic should be set to 4, since usually when something like a raider is found out, it's going to be 3 or 4 people ahelping, but that shouldn't cause it to trigger when an antag gets caught by sec and complains. Otherwise I think the overall panic value is good.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 13, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Nov 14, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
@TheShuEd TheShuEd added P1: High Priority: Higher priority than other items, but isn't an emergency. D2: Medium Difficulty: A good amount of codebase knowledge required. A: Admin Tooling Area: Admin tooling and moderation. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 15, 2024
@PJB3005 PJB3005 self-assigned this Dec 14, 2024
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 21, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/M Denotes a PR that changes 100-999 lines. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Admin Tooling Area: Admin tooling and moderation. D2: Medium Difficulty: A good amount of codebase knowledge required. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on
Projects
Status: 👀 Needs Review
Development

Successfully merging this pull request may close these issues.

Ahelp volume based panic bunker
5 participants