Remove Contact Slowdown when Weightless or in the Air #33299
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S: Needs Review
|
Even if this buffs flyers it doesn't make sense to be slowed by glue or affected by ice (the latter probably needs to be checked out here or another PR) |
SlamBamActionman
added
the
S: Untriaged
|
I've done some testing with ice and it seems to be a non-issue; it does not affect entities that are weightless or in the air. |
TheShuEd
requested changes
Nov 14, 2024
| @@ -81,6 +83,11 @@ private void MovementSpeedCheck(EntityUid uid, SpeedModifiedByContactComponent c | |||
| if (!EntityManager.TryGetComponent<PhysicsComponent>(uid, out var physicsComponent)) | |||
| return; | |||
|
|
|||
| // entities that are weightless, i.e. no gravity, should not be affected by contact slowdowns | |||
| // entities that are in the air, i.e. flying mobs, should not be affected by contact slowdowns | |||
| if (_gravity.IsWeightless(uid) || physicsComponent.BodyStatus == BodyStatus.InAir) | |||
There was a problem hiding this comment.
Ok we can have full-tile meat kudzu, rhat should slowdown in weightless state too
There was a problem hiding this comment.
I've gone ahead and fixed this interaction. In order to facilitate future code extensibility, I've added a new component that can be applied to entities that should still apply their contact slowdowns to airborne mobs. Let me know if you think this is fine or should be done in another way.
TheShuEd
added
P: Low
github-actions
bot
added
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Removes the application of contact slowdowns from puddles (i.e. glue, slime, etc.) when entities are weightless or in the air.
Why / Balance
Currently, contact slowdowns from puddles (i.e. glue, slime, etc.) apply even when entities are weightless or in the air, impacting both players under zero gravity and flying mobs such as Space Dragons and Space Carp. It does not make sense for ground-based slowdowns to affect weightless or flying entities.
I recognize that there exists minor balance implications as this PR slightly buffs the movement of all flying mobs, as well as reduces the utility of space glue in zero gravity situations, but I believe that such buffs are sufficiently minor to warrant a change that more intuitively aligns contact slowdowns with in-game physics.
Technical details
Media
Weightless.mp4
FlyingMobs.mp4
Requirements
Breaking changes
Changelog
🆑 Vexerot