Fix mime broken vow alert #33300
Closed
Fix mime broken vow alert #33300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test fail appears to be a lie |
swap VowBrokenAlert and VowAlert in the section about retaking the vow so that the proper alerts are cleared and shown
CheddaCheez
force-pushed
the
MimeTime14
branch
from
45bb538
to
e0c0c36
Compare
swap VowBrokenAlert and VowAlert in the section about retaking the vow so that the proper alerts are cleared and shown
github-actions
bot
added
the
Changes: No C#
|
I fudged something trying to amend a commit message and I'm not enough of a wizard to fix it so I'll reopen. Lessons learned! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes mimes being unable to break their vow after the first time.
Currently, upon retaking their vow, the mime gets their power back, but the alert still shows the vow as broken.
Clicking it after that point gives the "you aren't ready to repent" pop-up and stays that way forever.
Why / Balance
Literally broken alert needs fixing.
Technical details
This swaps two pieces in MimePowersSystem.cs in the section involving retaking the vow.
What is showing in-game at that point is VowBrokenAlert, but the code clears VowAlert instead.
Switch their places and it works as intended.
Requirements
Breaking changes
Changelog
🆑