Added branch to EndRound method and unit to round-end-system.ftl #33304
Conversation
SlamBamActionman
added
the
S: Untriaged
SaphireLattice
added
T: Bugfix
There was a problem hiding this comment.
Honestly this is kinda an area of localisation. As in, the numbers should have some kind of formatter/whatever that lets you pick different forms of word for different numbers.
E.g. Russian requires specific words for groups of: ending on 1, ending on 2-4, ending on 5-9 or it's a number 10-20 (inclusive). (Er, might be missing some nuance, but yeah)
English is, afaik, just "Is it exactly 1? Singular. Otherwise plural"
Which we do actually have support for!
| round-end-system-round-restart-eta-announcement = Restarting the round in {$time} {$units}... | ||
|
|
||
| eta-units-minute = minute | ||
| eta-units-minutes = minutes | ||
| eta-units-seconds = seconds |
There was a problem hiding this comment.
| round-end-system-round-restart-eta-announcement = Restarting the round in {$time} {$units}... | |
| eta-units-minute = minute | |
| eta-units-minutes = minutes | |
| eta-units-seconds = seconds | |
| round-end-system-round-restart-eta-announcement = Restarting the round in {$time} {$units}... | |
| eta-units-minutes = {$amount -> | |
| [one] minute | |
| *[other] minutes | |
| } | |
| eta-units-seconds = {$amount -> | |
| [one] second | |
| *[other] seconds | |
| } |
Note that this will require the units's Loc.GetString(unitsLocString) to supply time as well. Ideally you would change it all to be a bit better somehow, e.g. have the time string generated separately and just substituted into the "restarting the round..."
Also this sorta "minutes" and "seconds" stuff probably should be moved into being its own thing somewhere and have this just reference it somehow. But dunno if this number stuff happens often enough to warrant it.
SaphireLattice
added
D3: Low
About the PR
Addressing issue " small typo in the round restart chat alert #9797"
Why / Balance
This is my first contribution to an open source project so please be gentle. This seems like a frivolous change but it was accepted as an open issue so I decided to address it. I had to moc some values as I could not figure out how to get the restartround time under 120 seconds but I believe it will work if this turns out to be the case.
Technical details
I really just added an if condition to the existing EndRound method.
Media
Requirements
Breaking changes
I don't believe there should be any breaking changes for the English version but I'm an ignorant American and have no idea how to update the round-end-system.ftl file for other languages.
Personal Note
Please let me know how I can name PR's better or associate the PR to an open issue or any other advice you can give. I'm hear to practice good code, not a gamer actually.