Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds paper label visuals to closets and lockers #33318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds paper label visuals to closets and lockers #33318

wants to merge 2 commits into from
+64 −2

Conversation

SpaceRox1244
Copy link
Contributor

@SpaceRox1244 SpaceRox1244 commented Nov 14, 2024 •
edited
Loading

About the PR

Adds visuals for attaching a paper, like a cargo bounty or invoice, to a closet.

Why / Balance

Closets can accept paper labels the same way that crates can, but they dont currently have a visual for it. I want to be able to label my department locker so nobody touches it!!

Technical details

Media

labels

Requirements

Breaking changes

Changelog

🆑 SpaceRox1244

  • add: Closets and lockers now have visuals for being labeled with papers.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 30-99 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

RSI Diff Bot; head commit 20538ea merging into 0437ec6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Storage/Crates/labels.rsi

State Old New Status
bounty Modified
captains_paper Modified
invoice Modified
paper Modified

Resources/Textures/Structures/Storage/closet_labels.rsi

State Old New Status
bounty Added
captains_paper Added
invoice Added
paper Added

@beck-thompson
Copy link
Contributor

I feel like CL is necessary its a cool feature

@SpaceRox1244
Copy link
Contributor Author

Well I suppose itd get people to notice it

@SaphireLattice SaphireLattice added P: Medium Priority: Isn't of critical or major priority, but should be looked at. S: Needs Review Status: Requires additional reviews before being fully accepted S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: General Interactions Area: General in-game interactions that don't relate to another area. C: New Feature Categorisation: New feature or content, or extending existing content C: Visual Change Categorisation: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 15, 2024
SaphireLattice
SaphireLattice approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@SaphireLattice SaphireLattice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah. Actually wanted to suggest this sort of thing as an alternative to the pen eject PR. Though my thought was to suggest adding more colored papers. Something for a future PR, I suppose.

Quite like it! I do wish there were more paper types and the visualizer was actually uh, not needing a sprite for each different paper... Probably not quite in scope of this, but does highlight that issue more.

Never considered that the lockers could just have the paper label slapped on them, that makes an idea of "lockers label themselves if you use an ID with action (not ID locked!)" I've had even less relevant.

A personal question: any chance morgue could be added? Not required, just a "nice-to-have".

@SpaceRox1244
Copy link
Contributor Author

A personal question: any chance morgue could be added? Not required, just a "nice-to-have".

This PR was actually originally going to be about being able to label a whole bunch of new stuff, but I left it at the locker for now because I wanted to work on something else. I will probably come back to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaphireLattice SaphireLattice SaphireLattice approved these changes

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. C: New Feature Categorisation: New feature or content, or extending existing content C: Visual Change Categorisation: Deals with changes to art, sprites or other visuals in the game. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. P: Medium Priority: Isn't of critical or major priority, but should be looked at. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpaceRox1244 @beck-thompson @SaphireLattice