Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow upgrading windows by adding materials halfway through deconstruction #34268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Blackern5000
Copy link
Contributor

About the PR

You can now upgrade windows similarly to #31978, which was removed by #33160, however now there are constructions steps involved so it's not just magically applying materials for stronger window. These steps are the same for all windows:
Start the regular deconstructions steps, but halfway through add the material for upgrading. Upon completing the deconstruction steps the window will now upgrade instead of deconstructing.
The time needed to complete the latter half of the steps after adding the material is decreased (except for the shuttle window upgrade) only if the material was added, so it is significantly more convenient than fully deconstructing and building the new window in place of the old one.

I was thinking of adding a tip for this since it's a pretty hard feature to come across on your own, but I'm not sure how to word it well. I'm open to suggestions.

(Also adds directly building directional uranium windows since uhh that wasn't a thing for some reason. Also directly building frosted windows but they don't function yet.)

Why / Balance

Quote from my original PR for window upgrading:

So basically, trying to upgrade ANYTHING as an engineer has just been absolutely horrible. You'd first need to get the materials, craft them together, remove the old window, possibly mess with some grilles and float around in space, and chances are you won't even get everything done in time.

With the original pr, upgrading windows wasn't just convenient, it was pathetically easy. You could just walk right up to a window, apply rods/plasma/plasteel, and suddenly in just 5 seconds or less you have a SIGNIFICANTLY stronger window for a fraction of the time investment.
With this, it's still much faster and much easier (the entire point of having this, so engineers don't have to struggle as much trying to pre-emptively guard against station damage such as meteors.), but you still need to use welding tools for upgrading reinforced windows and can't just slap some plasteel onto the permabrig, cell windows, or sec front door as hos or warden and make it effectively immune to escape attempts, riots, or break-ins.

Media

2025-01-07.04-52-43.mp4

Requirements

Changelog
🆑

  • add: Normal and reinforced windows have once again been made directly upgradable by adding rods, plasma, uranium, or plasteel exactly half-way through the deconstruction process of the window being upgraded.
  • add: You can now build directional uranium windows and directional reinforced uranium windows from the construction menu.
  • add: You can now build directional frosted windows from the construction menu, despite them being non-functional and only acting as regular directional windows.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Jan 7, 2025
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Engineering Area: Engineering department, including Atmospherics. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 7, 2025
Copy link
Contributor

@dffdff2423 dffdff2423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not see anything wrong with the code. However, I have not really done much with construction graphs. I think this is a great QOL feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Engineering Area: Engineering department, including Atmospherics. A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants