Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mail Resprite #35776

Merged
merged 5 commits into from
Mar 11, 2025
Merged

Mail Resprite #35776

merged 5 commits into from
Mar 11, 2025

Conversation

Pronana
Copy link
Contributor

@Pronana Pronana commented Mar 11, 2025

About the PR

Mail now has brand new sprites! Death to mixels! Also cabnetification!

Why / Balance

Mixels are bad and cringe. Also mail didn't have inhand sprites.

Technical details

Changed the sprites and corresponding yaml and json files.

Media

image
image

Requirements

Breaking changes

Changelog

no cl no fun. in fact i hate fun more than i hate mixels.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Mar 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025 •
edited
Loading

RSI Diff Bot; head commit e7a43d7 merging into 38615b7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Cargo/mail.rsi

State Old New Status
broken Modified
fragile Modified
icon Modified
locked Modified
postmark Modified
priority Modified
priority_inactive Modified
trash Modified
inhand-left Added
inhand-right Added

Resources/Textures/Objects/Specific/Cargo/mail_large.rsi

State Old New Status
broken Modified
fragile Modified
icon Modified
inhand-left Modified
inhand-right Modified
locked Modified
postmark Modified
priority Modified
priority_inactive Modified
trash Modified

Edit: diff updated after e7a43d7

@ArtisticRoomba
Copy link
Contributor

cabinet mail real...

@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Mar 11, 2025
ArtisticRoomba
ArtisticRoomba suggested changes Mar 11, 2025
View reviewed changes
Resources/Textures/Objects/Specific/Cargo/mail.rsi/meta.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new json file needs to be 4 spaced

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed for both files

@slarticodefast
Copy link
Member

you got a zip file in there

@Pronana
Copy link
Contributor Author

Pronana commented Mar 11, 2025

you got a zip file in there

Always forgetting something. Oops

@Emisse Emisse added the S: Art Approval Status: The art (e.g. Spritework) has been approved by an art lead. label Mar 11, 2025
Pronana added 2 commits March 10, 2025 22:31
@Pronana
init commit
3bdab00
@Pronana
Merge remote-tracking branch 'origin/mail-resprite' into mail-resprite
fcd1b70 
# Conflicts:
#	Resources/Textures/Objects/Specific/Cargo/mail.rsi/meta.json
#	Resources/Textures/Objects/Specific/Cargo/mail_large.rsi/meta.json
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Mar 11, 2025
@Pronana
Copy link
Contributor Author

Pronana commented Mar 11, 2025

you got a zip file in there

It's gone now

ScarKy0
ScarKy0 requested changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put your github in the attributions as well

@Warpzoned
Copy link

The cardboard boxes look way too dark, soggy even, I would personally lighten them up a bit! (Consequentially, you should also lighten the NT purple markings so that they're just a slight contrast)

Otherwise their shape and the envelope's sprite look awesome, great job. ^^)b

ScarKy0
ScarKy0 approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has arttainer approval and looks fine to me soooo...

@ScarKy0 ScarKy0 merged commit 81a1ae1 into space-wizards:master Mar 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScarKy0 ScarKy0 ScarKy0 approved these changes

@ArtisticRoomba ArtisticRoomba Awaiting requested review from ArtisticRoomba

Assignees
No one assigned
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Art Approval Status: The art (e.g. Spritework) has been approved by an art lead. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pronana @ArtisticRoomba @slarticodefast @Warpzoned @ScarKy0 @Emisse