Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore the order of admin overlay elements #35783

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Restore the order of admin overlay elements #35783

merged 1 commit into from
Mar 11, 2025

Conversation

Errant-4
Copy link
Member

@Errant-4 Errant-4 commented Mar 11, 2025 •
edited
Loading

About the PR

Layout of the overlay is now once again Character, then Username

Why / Balance

The order was changed by accident when the draw code was refactored

Media

master branch
Screenshot_2025-03-11_173006

PR (also the stable branch)
image

Requirements

Changelog
🆑 Errant
ADMIN:

  • fix: The admin overlay once again shows the character name in the top line.

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted labels Mar 11, 2025
slarticodefast
slarticodefast approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple enough

@slarticodefast slarticodefast merged commit a6d66e6 into space-wizards:master Mar 11, 2025
17 checks passed
@Errant-4 Errant-4 deleted the overlayfix branch March 11, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@nikthechampiongr nikthechampiongr Awaiting requested review from nikthechampiongr nikthechampiongr is a code owner

@crazybrain23 crazybrain23 Awaiting requested review from crazybrain23 crazybrain23 is a code owner

Assignees
No one assigned
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Errant-4 @slarticodefast