Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roleban command error handling #35784

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Roleban command error handling #35784

merged 1 commit into from
Mar 12, 2025

Conversation

Errant-4
Copy link
Member

About the PR

Roleban command no longer crashes the debug client if a non-existant job is specified

Why / Balance

#35266 Most people agree that the client crashing is a bad thing

Technical details

Now it tries to index the job before passing it to the next system.

Media

image

Requirements

Breaking changes

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. labels Mar 11, 2025
beck-thompson
beck-thompson approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems smart! Tested and it works 👍

@beck-thompson beck-thompson merged commit 3d898ed into space-wizards:master Mar 12, 2025
17 checks passed
@Errant-4 Errant-4 deleted the roleban-command-job branch March 12, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beck-thompson beck-thompson beck-thompson approved these changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@nikthechampiongr nikthechampiongr Awaiting requested review from nikthechampiongr nikthechampiongr is a code owner

@crazybrain23 crazybrain23 Awaiting requested review from crazybrain23 crazybrain23 is a code owner

Assignees
No one assigned
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Errant-4 @beck-thompson