Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't duplicate logger fields #15

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

truszkowski
Copy link
Contributor

Now, we have duplicated fields in logs:

{... "msg":"scaling down ASG and killing worker", ... , "aws_request_id": "...", "aws_request_id": "...", ... "worker_id": "...", "instance_id": "...", "worker_id": "...", "instance_id": "...", ... }

We should reuse the logger, and just pass with new fields to the new logger variable.

@truszkowski truszkowski requested a review from a team as a code owner August 22, 2024 13:10
@truszkowski truszkowski requested review from a team and ilya-hontarau and removed request for a team August 22, 2024 13:10
@truszkowski truszkowski merged commit 41323ce into main Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants