Merge pull request #551 from spacelift-io/CU-862jx0n8q_Remove-legacy-…

…space-for-new-accounts_Jakub-Wjtowicz Updated docs to consider legacy space not being present
spacelift-io · May 17, 2024 · 306b856 · 306b856
2 parents 8a90a60 + 91910b8
commit 306b856
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 11 deletions.
diff --git a/docs/resources/idp_group_mapping.md b/docs/resources/idp_group_mapping.md
@@ -19,10 +19,6 @@ resource "spacelift_idp_group_mapping" "test" {
     space_id = "root"
     role     = "ADMIN"
   }
-  policy {
-    space_id = "legacy"
-    role     = "ADMIN"
-  }
 }
 ```
 

diff --git a/docs/resources/stack.md b/docs/resources/stack.md
@@ -248,7 +248,7 @@ resource "spacelift_stack" "terragrunt-stack" {
 - `runner_image` (String) Name of the Docker image used to process Runs
 - `showcase` (Block List, Max: 1) (see [below for nested schema](#nestedblock--showcase))
 - `slug` (String) Allows setting the custom ID (slug) for the stack
-- `space_id` (String) ID (slug) of the space the stack is in. Defaults to `legacy`.
+- `space_id` (String) ID (slug) of the space the stack is in. Defaults to `legacy` if it exists, otherwise `root`.
 - `terraform_external_state_access` (Boolean) Indicates whether you can access the Stack state file from other stacks or outside of Spacelift. Defaults to `false`.
 - `terraform_smart_sanitization` (Boolean) Indicates whether runs on this will use terraform's sensitive value system to sanitize the outputs of Terraform state and plans in spacelift instead of sanitizing all fields. Note: Requires the terraform version to be v1.0.1 or above. Defaults to `false`.
 - `terraform_version` (String) Terraform version to use

diff --git a/examples/resources/spacelift_idp_group_mapping/resource.tf b/examples/resources/spacelift_idp_group_mapping/resource.tf
@@ -4,8 +4,4 @@ resource "spacelift_idp_group_mapping" "test" {
     space_id = "root"
     role     = "ADMIN"
   }
-  policy {
-    space_id = "legacy"
-    role     = "ADMIN"
-  }
 }
diff --git a/spacelift/data_spaces_test.go b/spacelift/data_spaces_test.go
@@ -13,7 +13,7 @@ func TestSpacesData(t *testing.T) {
 		datasourceName := "data.spacelift_spaces.test"
 
 		testSteps(t, []resource.TestStep{{
-			// Should find at least the legacy and root spaces.
+			// Should find at least root space.
 			Config: `
 				data "spacelift_spaces" "test" {
 				}

diff --git a/spacelift/resource_stack.go b/spacelift/resource_stack.go
@@ -552,7 +552,7 @@ func resourceStack() *schema.Resource {
 			},
 			"space_id": {
 				Type:        schema.TypeString,
-				Description: "ID (slug) of the space the stack is in. Defaults to `legacy`.",
+				Description: "ID (slug) of the space the stack is in. Defaults to `legacy` if it exists, otherwise `root`.",
 				Optional:    true,
 				Computed:    true,
 			},