Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worker deployments for spackbotdev #333

Merged

Conversation

kwryankrattiger
Copy link
Collaborator

@kwryankrattiger kwryankrattiger force-pushed the spackbot_pr_binary_graduation branch 3 times, most recently from 6e87bcb to 6ac1e6d Compare October 27, 2022 15:11
@kwryankrattiger kwryankrattiger marked this pull request as ready for review October 27, 2022 15:22
@kwryankrattiger
Copy link
Collaborator Author

@zackgalbreath I moved the close stuff to spackbot since I am also deleting the mirror there spack/spackbot#68

Could you review those changes to make sure I didn't break something else as well.

Copy link
Collaborator

@zackgalbreath zackgalbreath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to bump the version number for gh-gl-sync in .github/workflows/custom_docker_builds.yml and k8s/custom/gh-gl-sync/cron-jobs.yaml

Copy link
Collaborator

@scottwittenburg scottwittenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good @kwryankrattiger thanks! Couple requests:

I feel like this is not rebased on the latest main, to make it easier for me to make another review pass, can you rebase it?

Somehow the nested contents of the volumes and volumeMounts sections in the deployments are indented differently between spackbot-spack-io and spackbotdev-spack-io. Can you make them match?

Thanks!

@kwryankrattiger kwryankrattiger force-pushed the spackbot_pr_binary_graduation branch from 1db170d to 6904660 Compare November 8, 2022 16:51
@kwryankrattiger kwryankrattiger force-pushed the spackbot_pr_binary_graduation branch from bff8ab0 to 289061b Compare November 11, 2022 22:18
@zackgalbreath zackgalbreath self-requested a review November 11, 2022 22:30
@scottwittenburg scottwittenburg merged commit ad7cdb8 into spack:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants