-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add worker deployments for spackbotdev #333
Add worker deployments for spackbotdev #333
Conversation
6e87bcb
to
6ac1e6d
Compare
@zackgalbreath I moved the close stuff to spackbot since I am also deleting the mirror there spack/spackbot#68 Could you review those changes to make sure I didn't break something else as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also need to bump the version number for gh-gl-sync in .github/workflows/custom_docker_builds.yml
and k8s/custom/gh-gl-sync/cron-jobs.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good @kwryankrattiger thanks! Couple requests:
I feel like this is not rebased on the latest main
, to make it easier for me to make another review pass, can you rebase it?
Somehow the nested contents of the volumes
and volumeMounts
sections in the deployments are indented differently between spackbot-spack-io and spackbotdev-spack-io. Can you make them match?
Thanks!
1db170d
to
6904660
Compare
bff8ab0
to
289061b
Compare
@scottwittenburg