Merge pull request #54 from etahamer/main

PendingShortScheduleCommand::command method will attempt to resolve command name if class name was given

README.md

@@ -21,6 +21,9 @@ protected function shortSchedule(\Spatie\ShortSchedule\ShortSchedule $shortSched
 
     // this command will run every half a second
     $shortSchedule->command('another-artisan-command')->everySeconds(0.5);
+
+    // this command will run every second and its signature will be retrieved from command automatically
+    $shortSchedule->command(\Spatie\ShortSchedule\Tests\Unit\TestCommand::class)->everySecond();
 }
 ```
 
@@ -89,6 +92,9 @@ protected function shortSchedule(\Spatie\ShortSchedule\ShortSchedule $shortSched
 {
     // this artisan command will run every second
     $shortSchedule->command('artisan-command')->everySecond();
+
+    // this artisan command will run every second, its signature will be resolved from container
+    $shortSchedule->command(\Spatie\ShortSchedule\Tests\Unit\TestCommand::class)->everySecond();
 }
 ```
 

src/PendingShortScheduleCommand.php

@@ -3,6 +3,7 @@
 namespace Spatie\ShortSchedule;
 
 use Closure;
+use Illuminate\Container\Container;
 use Illuminate\Support\Arr;
 use Spatie\ShortSchedule\RunConstraints\BetweenConstraint;
 use Spatie\ShortSchedule\RunConstraints\EnvironmentConstraint;
@@ -35,8 +36,12 @@ public function everySeconds(float $frequencyInSeconds = 1): self
         return $this;
     }
 
-    public function command(string $artisanCommand):self
+    public function command(string $artisanCommand): self
     {
+        if (class_exists($artisanCommand)) {
+            $artisanCommand = app($artisanCommand)->getName();
+        }
+
         $this->command = PHP_BINARY . " artisan {$artisanCommand}";
 
         return $this;

tests/Unit/PendingShortScheduleCommandTest.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types=1);
+
+namespace Spatie\ShortSchedule\Tests\Unit;
+
+use Illuminate\Console\Command;
+use Orchestra\Testbench\TestCase as Orchestra;
+use ReflectionClass;
+use Spatie\ShortSchedule\PendingShortScheduleCommand;
+
+class PendingShortScheduleCommandTest extends Orchestra
+{
+    /** @test */
+    public function it_will_generate_command_from_command_class(): void
+    {
+        $pendingCommand = new PendingShortScheduleCommand();
+        $pendingCommand->command(TestCommand::class);
+        $reflectionClass = new ReflectionClass($pendingCommand);
+
+        $commandProperty = $reflectionClass->getProperty('command');
+        $commandProperty->setAccessible(true);
+
+        $artisanCommand = 'test-command';
+        $this->assertEquals(PHP_BINARY . " artisan {$artisanCommand}", $commandProperty->getValue($pendingCommand));
+    }
+}
+
+class TestCommand extends Command
+{
+    protected $signature = 'test-command';
+
+    public function handle(): void
+    {
+    }
+}