Add useEncoding to SimpleExcelReader #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
useEncoding
method toSimpleExcelReader
to allow use of custom encodings (SHIFT_JIS, EUC_JP, etc).Currently, opening files in encodings other than UTF-8 can lead to garbled output. This allows us to set the exact encoding we want the data to be in.
This also enables us to check what encoding our data is in. An example:
I am not sure if this should be something this library should handle, but if needed, I can make a PR for that as well.