Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(languages): add support for Jule #504

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

adamperkowski
Copy link
Contributor

hey! this add support for Jule.
https://jule.dev
https://github.com/julelang

.jule isn't used by any other system AFAIK

@adamperkowski adamperkowski requested a review from o2sh as a code owner February 2, 2025 15:12
@adamperkowski
Copy link
Contributor Author

cc @spenserblack

@spenserblack
Copy link
Owner

Thanks! Would you like to add a code sample?

@spenserblack spenserblack added the new-language Requests to add a new language label Feb 2, 2025
@spenserblack
Copy link
Owner

@all-contributors add @adamperkowski for data

Copy link
Contributor

@spenserblack

I've put up a pull request to add @adamperkowski! 🎉

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.20%. Comparing base (5775217) to head (e432e6b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   71.20%   71.20%           
=======================================
  Files          18       18           
  Lines         521      521           
=======================================
  Hits          371      371           
  Misses        150      150           
Flag Coverage Δ
--no-default-features 72.22% <ø> (ø)
--no-default-features --features color 70.82% <ø> (ø)
ubuntu-latest 71.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamperkowski
Copy link
Contributor Author

adamperkowski commented Feb 2, 2025

Thanks! Would you like to add a code sample?

sure. on it

@spenserblack
Copy link
Owner

Thanks for adding a sample! Sorry to be really nitpicky, but can it be a sample that you yourself authored (#339)?

I'm trying to avoid copying samples from other sources, except in situations where the original author has provided permission. Without going too much into a legal rant, I believe that these samples qualify as "significant portions" that trigger permissive licenses' requirement to include a copy of the license, and that inclusion in a public repository can qualify as redistribution. So it's simply less risky for the original author to provide the sample.

@adamperkowski
Copy link
Contributor Author

I'm trying to avoid copying samples from other sources, except in situations where the original author has provided permission. Without going too much into a legal rant, I believe that these samples qualify as "significant portions" that trigger permissive licenses' requirement to include a copy of the license, and that inclusion in a public repository can qualify as redistribution. So it's simply less risky for the original author to provide the sample.

i understand this. i care about oss licenses and am glad that you do too.
that sample was written by @mertcandav, we have his permission.
on top of that, we decided to license it under CC0 1.0 public domain.

@mertcandav
Copy link

Hi. The designer and author of the Jule programming language is here.

As @adamperkowski said, I wrote the samples and we decided to license it under CC0 1.0 public domain.
Please feel free to using them.

Thanks for the nice work, and adding support for Jule.

Copy link
Owner

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all!

@spenserblack spenserblack enabled auto-merge (squash) February 3, 2025 13:42
@spenserblack
Copy link
Owner

I'll make sure to give @mertcandav credit, too, as the original author of the sample 🙂

@all-contributors add @mertcandav for data

Copy link
Contributor

@spenserblack

I've put up a pull request to add @mertcandav! 🎉

@spenserblack spenserblack merged commit 8f73faf into spenserblack:main Feb 3, 2025
18 of 19 checks passed
@adamperkowski adamperkowski deleted the feat/jule branch February 3, 2025 13:47
@mertcandav
Copy link

I'll make sure to give @mertcandav credit, too, as the original author of the sample 🙂

@all-contributors add @mertcandav for data

Thank you.

Copy link
Contributor

@mertcandav

@mertcandav already contributed before to data

@spenserblack
Copy link
Owner

BTW publishing new releases is very trivial for me, so if you're waiting for this feature to be published and would like a new release, just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-language Requests to add a new language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants