Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch test/javascript when creating Devcontainer #525

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

ankddev
Copy link
Contributor

@ankddev ankddev commented Feb 28, 2025

Closes #138

Description

I've updated postCreate.sh script to firstly check origin and if it's equal to https://github.com/spenserblack/gengo, run git fetch origin test/javascript:test/javascript, else git fetch upstream test/javascript:test/javascript

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.59%. Comparing base (ac6dcca) to head (f33f7e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   71.59%   71.59%           
=======================================
  Files          18       18           
  Lines         521      521           
=======================================
  Hits          373      373           
  Misses        148      148           
Flag Coverage Δ
--no-default-features 72.63% <ø> (ø)
--no-default-features --features color 71.20% <ø> (ø)
ubuntu-latest 71.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to unconditionally add a remote and fetch from it instead. Check out how github-linguist does it.

@spenserblack spenserblack added the ignore-for-release This pull request should not be included in a release label Feb 28, 2025
@ankddev ankddev requested a review from spenserblack February 28, 2025 14:03
spenserblack
spenserblack previously approved these changes Feb 28, 2025
@spenserblack spenserblack merged commit 025132e into spenserblack:main Feb 28, 2025
21 checks passed
@ankddev ankddev deleted the devcontainer-call-git-fetch branch February 28, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release This pull request should not be included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git fetch origin test/javascript:test/javascript when creating devcontainer
2 participants