Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spin-redirector component needs updating #12

Closed
vdice opened this issue Mar 24, 2025 · 3 comments
Closed

spin-redirector component needs updating #12

vdice opened this issue Mar 24, 2025 · 3 comments

Comments

@vdice
Copy link
Contributor

vdice commented Mar 24, 2025

I think the spin-redirecter component (and/or maybe other associated config?) needs to be updated. For instance, I'd expect /quickstart to redirect to /v3/quickstart but currently the former leads to a 404.

Wondering if @karthik2804 has cycles to take a look.

@karthik2804
Copy link
Contributor

@vdice the trigger route is not setup correctly anymore

spin-docs/spin.toml

Lines 127 to 130 in 8ce8ac1

[[trigger.http]]
id = "trigger-spin-version-proxy"
component = "spin-version-proxy"
route = "/spin/..."
.

The logic on the component should also change since we do not have nested directories anymore and we want / to be served as is but have versioned servicing for /{some_path}.
On another note, I think we should update the redirector to a newer version of the JS SDK or rewrite it in rust.

@vdice
Copy link
Contributor Author

vdice commented Mar 25, 2025

@karthik2804 I can't quite figure this one out despite adjusting things in what looked like the right way. I'm sure I'm missing something obvious. Could you take a crack at it?

I'd say just getting it working again would be top priority and would vote for a follow-up to revamp the component logic (JS SDK rev or diff SDK), unless you get in the zone and can knock it out rapidly as well!

@vdice
Copy link
Contributor Author

vdice commented Mar 27, 2025

Closed by #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants