Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(.github): add build.yml; defer linting for now #28

Merged
merged 3 commits into from
Mar 27, 2025
Merged

ci(.github): add build.yml; defer linting for now #28

merged 3 commits into from
Mar 27, 2025

Conversation

vdice
Copy link
Contributor

@vdice vdice commented Mar 26, 2025

Copy link

🚀 preview deployed successfully to Fermyon Cloud and available at https://spin-docs-pr-28-zjhltipy.fermyon.app

@itowlson
Copy link
Contributor

At least some of those broken links come from changes being made to the JS SDK links.

# Original site - correct
https://spinframework.github.io/spin-js-sdk/stable/interfaces/Llm.EmbeddingResult.html
# Now - broken
https://fermyon.github.io/spin-js-sdk/interfaces/Llm.EmbeddingResult.html

The old fermyon.github.io doesn't redirect, and the stable is required.

@itowlson
Copy link
Contributor

itowlson commented Mar 27, 2025

Eek, when was the spin-docs site forked/copied? Those got updated on the original site in mid-February (https://github.com/fermyon/developer/pull/1477/files). Are we working off a 6-week old version of the docs? Older?

ETA: Yes we are. Recent changes are just missing from this version of the site. Looking to see how far back we need to go.

@itowlson
Copy link
Contributor

I'm working my way through the backports (for avoidance of duplicate effort!)

@vdice
Copy link
Contributor Author

vdice commented Mar 27, 2025

Phew, thanks for corraling all of the backports we need @itowlson.

@vdice
Copy link
Contributor Author

vdice commented Mar 27, 2025

I see a few more broken links to trim down, asides from the otherwise known (#24 and #12); PR soon.

@vdice
Copy link
Contributor Author

vdice commented Mar 27, 2025

Oops, 1f8ee63 was meant to land in #38 but I forgot to save my open VS Code tab. Sneaking it into this PR.

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible spurious file? Otherwise LGTM

@vdice vdice merged commit 9b0d622 into main Mar 27, 2025
2 of 3 checks passed
@vdice vdice deleted the ci/build branch March 27, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants