ci(.github): add deploy.yaml #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 preview deployed successfully to Fermyon Cloud and available at https://spin-docs-pr-36-p2uhomrv.fermyon.app |
vdice
force-pushed
the
ci/deploy-site
branch
2 times, most recently
from
f79e556 to
914309e
Compare
Signed-off-by: Vaughn Dice <[email protected]>
itowlson
approved these changes
Mar 27, 2025
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: app | ||
| # These are all of the paths referenced in spin.toml |
There was a problem hiding this comment.
I'm a bit concerned about the maintenance implications here but it's not a blocker
There was a problem hiding this comment.
Yes, I am as well... I took inspiration from another website/app (Finicky Whiskers) as I liked the flow of "build, save artifacts, deploy artifacts" but this site has many more files to track. Maybe all we need is a better pattern matching approach... eg something as simple as a "not node_modules" negation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the deploy.yaml to trigger website deploys on merges to main
Needs rebase after ci(.github): add build.yml; defer linting for now #28