Taking a first crack at implementing metrics #2475
Merged
+252
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebschoepp
commented
Apr 25, 2024
lann
reviewed
Apr 26, 2024
lann
reviewed
Apr 26, 2024
Closed
itowlson
reviewed
Apr 28, 2024
calebschoepp
force-pushed
the
otel-metrics-via-tracing
branch
2 times, most recently
from
d2d45bb to
06af58e
Compare
lann
approved these changes
Apr 29, 2024
Signed-off-by: Caleb Schoepp <[email protected]>
calebschoepp
force-pushed
the
otel-metrics-via-tracing
branch
from
06af58e to
1b0f40d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my recommended approach for how we do metrics in Spin and supersedes #2469.