Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipeline_template): Add support of semver for template tags #993

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

micnncim
Copy link
Member

@micnncim micnncim commented Nov 11, 2020

Resolves spinnaker/spinnaker#5569

This PR would add support of semver for pipeline template tags. Seems many users want such a option in the above issue.

The regex pattern is the almost same as:

public static final String VERSION_PATTERN = "^[0-9]\\d*\\.\\d+\\.\\d+(?:-[a-zA-Z0-9]+)?$";
and also supports v prefix as an option.

@micnncim micnncim force-pushed the pipeline-template/support-semver branch from 28206e1 to a58acff Compare November 11, 2020 17:52
@micnncim micnncim changed the title feat(pipeline_template): Support semver for template tags feat(pipeline_template): Add support of semver for template tags Nov 11, 2020
@micnncim micnncim force-pushed the pipeline-template/support-semver branch from a58acff to abd1e76 Compare November 11, 2020 17:55
@micnncim

This comment has been minimized.

@micnncim micnncim force-pushed the pipeline-template/support-semver branch from abd1e76 to abd91c4 Compare November 15, 2020 17:02
@micnncim
Copy link
Member Author

@ajordens @jonsie @plumpy
I’m not sure you’re some of the owners of this file but could you take a look at this PR?

@micnncim
Copy link
Member Author

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline Template tags should support SemVer
1 participant