Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #817 Allow specifying global extension order #818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #817 Allow specifying global extension order #818

wants to merge 1 commit into from

Conversation

tburny
Copy link
Contributor

@tburny tburny commented Jan 29, 2018

Allow specifying the order of global extensions explicitly.

For instance if

  • spock-spring provides the SpringExtension via its IGlobalExtension file,
  • MyProject provides com.example.MyExtension
  • and MyExtension depends on SpringExtension
    then the MyProject/src/main/resources/META-INF/services/org.spockframework.runtime.extension.IGlobalExtension would look like this:
org.spockframework.spring.SpringExtension
com.example.MyExtension

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 29, 2018

Codecov Report

Merging #818 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #818   +/-   ##
=========================================
  Coverage     74.45%   74.45%           
  Complexity     3327     3327           
=========================================
  Files           359      359           
  Lines         10355    10355           
  Branches       1292     1292           
=========================================
  Hits           7710     7710           
  Misses         2177     2177           
  Partials        468      468
Impacted Files Coverage Δ Complexity Δ
...pockframework/runtime/GlobalExtensionRegistry.java 90.9% <100%> (ø) 24 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01eb41...e528733. Read the comment docs.

@leonard84
Copy link
Member

Spock doesn't allow duplicate global extensions on the classpath see #738, this approach also doesn't deal with cycles and won't work with Java 9 modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants