Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Framework to net standrad 2.0 #148

Closed

Conversation

kamiff
Copy link
Contributor

@kamiff kamiff commented May 23, 2018

Change Framework to net standrad 2.0

Copy link

@luizcarlosfaria luizcarlosfaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??? Look this commit message ??? "adsadasd"

@irperez
Copy link

irperez commented Jun 10, 2018

Can someone please review and possibly merge this pull request? This is holding up our company from adopting spring.net/activemq.

@lahma
Copy link
Collaborator

lahma commented Jun 11, 2018

Thank you for your interest in helping out. Unfortunately this change won't be the silver bullet as it only Spring.Core and the build scripts won't even consider it. Spring.NET is built using old NAnt scripts that do not understand the .NET Core build concepts.

I spent some time checking required changes and there are still quite the work ahead.

There's also separate initiative #144 that is changing things on separate fork, might be worth the look.

If I just find the time I'd like to try to more conservative approach and try to introduce changes in steps. First one would be to change the build infra and csprojs to new format, without supporting .NET Core yet. So this is a multi-step process and probably will benefit from work started in #144 .

@luizcarlosfaria
Copy link

luizcarlosfaria commented Jun 20, 2018

@lahma The fork proposed on #144 by @jeffreyschultz has been paused.

My proposal fork is up and Running at https://github.com/Oragon/Oragon.Spring but has considerations:

  1. Only Spring.Core and Spring.AOP are migrated for .NET Standard.
  2. This fork has no improvements. The objective is ONLY work with Spring.NET on .NET Standard.
  3. It's not a competition, when original project will be migrated this project can be removed.

Looking around Spring.NET commits today, @lahma is working on this issue.

@lahma lahma force-pushed the features/netcore branch 4 times, most recently from 10247ff to 1e98aad Compare September 23, 2018 16:31
@lahma lahma force-pushed the features/netcore branch 2 times, most recently from 633b2a2 to b81af45 Compare September 30, 2018 06:34
@lahma
Copy link
Collaborator

lahma commented Sep 30, 2018

I'm closing this as obsolete. master branch now can compile relevant projects for .NET Framework 4.5.2 and netstandard20.

@lahma lahma closed this Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants