-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Framework to net standrad 2.0 #148
Conversation
…et.git Conflicts: src/Spring/Spring.Core/Spring.Core.csproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??? Look this commit message ??? "adsadasd"
Can someone please review and possibly merge this pull request? This is holding up our company from adopting spring.net/activemq. |
Thank you for your interest in helping out. Unfortunately this change won't be the silver bullet as it only Spring.Core and the build scripts won't even consider it. Spring.NET is built using old NAnt scripts that do not understand the .NET Core build concepts. I spent some time checking required changes and there are still quite the work ahead. There's also separate initiative #144 that is changing things on separate fork, might be worth the look. If I just find the time I'd like to try to more conservative approach and try to introduce changes in steps. First one would be to change the build infra and csprojs to new format, without supporting .NET Core yet. So this is a multi-step process and probably will benefit from work started in #144 . |
@lahma The fork proposed on #144 by @jeffreyschultz has been paused. My proposal fork is up and Running at https://github.com/Oragon/Oragon.Spring but has considerations:
Looking around Spring.NET commits today, @lahma is working on this issue. |
10247ff
to
1e98aad
Compare
633b2a2
to
b81af45
Compare
I'm closing this as obsolete. master branch now can compile relevant projects for .NET Framework 4.5.2 and netstandard20. |
Change Framework to net standrad 2.0