Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otel grafana #544

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Otel grafana #544

wants to merge 8 commits into from

Conversation

eduard-melnytskyi
Copy link
Contributor

Description

Extend local setup with the local opentelemetry stack

Change log

  • Added additional service grafana with all required sub-services, that allow to run locally opetelemetry stack.
  • Extended documentation with the information related to the service configuration

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

Comment on lines +676 to +679
grafana:
engine: otel-stack
endpoints:
grafana:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be put under the services node, right? I would include that:

Suggested change
grafana:
engine: otel-stack
endpoints:
grafana:
services:
grafana:
engine: otel-stack
endpoints:
grafana:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case, it is not necessary, as this file is all about configuring the services section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants