Bug 5092: improve https_port ssl-bump documentation #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinkie
added
the
backport-to-v6
rousskov
requested changes
Jan 13, 2025
rousskov
added
the
S-waiting-for-author
kinkie
added
backport-to-v7
rousskov
requested changes
Feb 28, 2025
There was a problem hiding this comment.
PR title promises to improve https_port documentation. PR code changes http_port documentation instead.
The above problem remains unaddressed.
From Bug 5092: I got a log message saying "FATAL: ssl-bump on https_port requires tproxy/intercept which is missing." and "FATAL: tproxy/intercept on https_port requires ssl-bump which is missing.". However, none of these information has been mentioned in [documentation]"
The current PR changes do not address Bug 5092!
| The ssl_bump option is required to fully enable | ||
| bumping of CONNECT requests. | ||
| This option is essentially ignored (with a WARNING message) | ||
| unless configuration also has ssl_bump directive(s). |
There was a problem hiding this comment.
Please fix/preserve 3-tabs indentation.
rousskov
added
S-waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.