993 progress: convert 3 more files to pytest #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replace unittest asserts with pytest asserts * remove maxDiff
sed -i.bak -E 's/self.assertEqual\((.*), (.*)\)/assert \1 == \2/' tests/test_collection.py note needed a bit of editing as multiple commas in one line could confuse sed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1520 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 54 54
Lines 7542 7542
Branches 915 915
=======================================
Hits 6899 6899
Misses 457 457
Partials 186 186 ☔ View full report in Codecov by Sentry. |
gadomski
approved these changes
Feb 6, 2025
|
Sure thing! Likewise I'm glad to be getting practice and catching up on newer stuff like type annotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #993
Description: Continued in the pattern for the previous 993 PR: Converted tests from unittest to pytest
PR Checklist:
pre-commit run --all-files)pytest)Documentation has been updated to reflect changes, if applicableor improvesoverall codebase code coverage.Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.