993 progress: convert 3 more files to pytest #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 54 54
Lines 7571 7571
Branches 922 922
=======================================
Hits 6927 6927
Misses 457 457
Partials 187 187 ☔ View full report in Codecov by Sentry. |
gadomski
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s): #993
Description: This time it's
tests/test_stac_io.py,tests/test_summaries.py, andtests/test_utils.py. For the latter I converted the biggest of the tests with internal loops to pytest's parametrize; a few tests intest_utils.pygot collapsed down to one with some redundancy (likely accidental) taken out. That's why it seems to run more tests (and skip more) than previously. Also there's some windows-only tests this time; I assume those will get run when this PR is submitted?PR Checklist:
pre-commit run --all-files)pytest)Documentation has been updated to reflect changes, if applicableor improvesoverall codebase code coverage.Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.