-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SparkSession configs statements if non-default namespace used #118
Added SparkSession configs statements if non-default namespace used #118
Conversation
Thank you for this PR! We'll take a look at this in the next few days. |
Hi @morooshka, The PR looks good overall, i will try to test tomorrow. We would like to keep the output (charts and tables) in the notebook though. This way you can e.g. see what the results look like e.g. via github as well or if anything goes wrong (e.g. like not enough memory etc.) during execution. Im fine with you doing it, otherwise i can push the executed notebook again including your changes. Cheers, |
OK, I'll repush it. I thought someone had forgotten to delete the outputs |
Hi @maltesander! I've repushed the notebook with outputs as requested |
Hey @morooshka, tested and works. Thank you! One nitpick, there is one typo
Otherwise we can merge :) |
OMG, thank you for noticing it, I'll repush |
@maltesander I have repushed, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries and thank you, looks good to me :)
Added SparkSession configs statements if non-default namespace used to the demo notebook. Otherwise the SparkSession would not be created with an error referring to the wrong namespace