Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stackable-versioned): Emit type parameter defaults #991

Merged

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Mar 21, 2025

Part of stackabletech/issues#642, needed for #968

Correctly emit type parameter defaults in generated enum and struct definitions.

NickLarsenNZ
NickLarsenNZ previously approved these changes Mar 21, 2025
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer requested a review from NickLarsenNZ March 24, 2025 08:06
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit e936f70 Mar 24, 2025
10 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/stackable-versioned-emit-type-parameter-defaults branch March 24, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants