Ensure ctest fails if no unit tests are found

[Molter73]

Description

Ensure ctest fails when not finding any tests to be run.

Additionally, unpin cmake version on Konflux builds and bring some changes over from downstream.

Checklist

• Investigated and inspected CI test results
• Updated documentation accordingly

Automated testing

• Added unit tests
• Added integration tests
• Added regression tests

If any of these don't apply, please comment below.

Testing Performed

• Check unit tests are properly run in konflux.

[Molter73]

Added @stackrox/rhtap-maintainers as reviewers for the konflux dockerfile changes.

[tommartensen]

You mention that the cmake version in Konflux doesn't support the --test-dir flag and therefore we need to do a workaround. Can we instead bump the cmake version in Konflux to one that does support the flag?

[Molter73]

You mention that the cmake version in Konflux doesn't support the --test-dir flag and therefore we need to do a workaround. Can we instead bump the cmake version in Konflux to one that does support the flag?

I would love to, but it is installed using dnf and I'm pretty sure it is using the latest available one.

[tommartensen]

Regarding cmake:
We (I) pinned the version to the same as downstream: https://gitlab.cee.redhat.com/stackrox/rhacs-midstream/-/blob/rhacs-1.0-rhel-8/distgit/containers/rhacs-collector/Dockerfile.in?ref_type=heads#L20.

podman run -it registry.access.redhat.com/ubi8/ubi:latest
[root@cdd583c3fe19 /]# dnf install -y cmake
...
======================================================================================================================================================================================================================
 Package                                            Architecture                              Version                                                    Repository                                              Size
======================================================================================================================================================================================================================
Installing:
 cmake                                              aarch64                                   3.26.5-2.el8                                               ubi-8-appstream-rpms                                    12 M
Installing dependencies:
 cmake-data                                         noarch                                    3.26.5-2.el8                                               ubi-8-appstream-rpms                                   1.9 M
 cmake-filesystem                                   aarch64                                   3.26.5-2.el8                                               ubi-8-appstream-rpms                                    45 k
 cmake-rpm-macros                                   noarch                                    3.26.5-2.el8                                               ubi-8-appstream-rpms                                    44 k
 emacs-filesystem                                   noarch                                    1:26.1-12.el8_10                                           ubi-8-baseos-rpms                                       70 k
 libuv                                              aarch64                                   1:1.41.1-2.el8_10                                          ubi-8-appstream-rpms                                   150 k
 make                                               aarch64                                   1:4.2.1-11.el8                                             ubi-8-baseos-rpms                                      490 k
 vim-filesystem                                     noarch                                    2:8.0.1763-19.el8_6.4                                      ubi-8-appstream-rpms                                    50 k

...

Installed:
  cmake-3.26.5-2.el8.aarch64           cmake-data-3.26.5-2.el8.noarch      cmake-filesystem-3.26.5-2.el8.aarch64            cmake-rpm-macros-3.26.5-2.el8.noarch      emacs-filesystem-1:26.1-12.el8_10.noarch
  libuv-1:1.41.1-2.el8_10.aarch64      make-1:4.2.1-11.el8.aarch64         vim-filesystem-2:8.0.1763-19.el8_6.4.noarch

Complete!
[root@cdd583c3fe19 /]# cmake --version
cmake version 3.26.5

CMake suite maintained and supported by Kitware (kitware.com/cmake).

There are newer CMake versions available, could you attempt to update? 🙏

[Molter73]

There are newer CMake versions available, could you attempt to update? 🙏

Was just checking and we unpinned the cmake version on the upstream builder 2 years ago, how did we not change this before? I'll try bumping it now.

[tommartensen]

LGTM. Konflux build succeeds and the integration tests with the Konflux image passes. Please ensure that the cmake change will be ported to midstream as well. 🙏