Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-27840: prefetch RPM dependencies for Konflux #1773

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

tommartensen
Copy link
Contributor

@tommartensen tommartensen commented Jan 17, 2025

How to reproduce the lockfile: https://spaces.redhat.com/display/StackRox/How+to+prefetch+RPMs+for+ACS+Konflux+builds

Required changes:

  • cannot blanket dnf upgrade, because we need to specify which RPMs to prefetch. Target RPMs can be added to the packages section for prefetching, see https://github.com/stackrox/scanner/pull/1793/files for an example (added to the How-to).
  • The lockfile tool cannot resolve ${BASE_REGISTRY}/${BASE_IMAGE}:${BASE_TAG}, thus changing that to the full image name. We haven't used build arg overrides anyway.
  • The repo definitions file ends with 2 empty lines, because we edit it with Python's configparser which intentionally adds them: https://bugs.python.org/issue32917.

Copy link

openshift-ci bot commented Jan 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tommartensen tommartensen changed the title [spike] prefetch RPM dependencies [spike] ROX-27638: prefetch RPM dependencies Jan 20, 2025
@tommartensen tommartensen changed the title [spike] ROX-27638: prefetch RPM dependencies ROX-27840: prefetch RPM dependencies for Konflux Jan 28, 2025
@tommartensen tommartensen marked this pull request as ready for review January 29, 2025 16:45
@tommartensen tommartensen requested a review from a team as a code owner January 29, 2025 16:45
Copy link

openshift-ci bot commented Jan 29, 2025

@tommartensen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 0f5fdb5 link false /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant