refactor: move 'image' properties up in the values.yaml file #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xakraz thanks for the PR, we will review it soon. On a side note, dont you think it should be major bump instead of a patch, since image placement change would be a breaking change? |
|
@MuneebAijaz , I wondered about the version bump. Thanks for considering it 🙏 |
|
Yes do a major bump instead |
xakraz
force-pushed
the
feat/imageValues
branch
from
5d93bb6 to
b59240e
Compare
karl-johan-grahn
requested changes
Feb 26, 2025
- Update the version number in the `Chart.yaml` file from `1.3.0` to `1.3.1` - Update the image name and tag in the `deployment.yaml` file - Add a new section for image details in the `values.yaml` file with repository, tag, and pull policy - Remove the `image` section from the `reloader` block in the `values.yaml` file, since the image details were moved to a new image section - Modify the `containerSecurityContext` section in the `deployment.yaml` file
xakraz
force-pushed
the
feat/imageValues
branch
from
b59240e to
71cc005
Compare
|
Thanks @karl-johan-grahn for the review 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
deployment.yamlfilevalues.yamlfile with repository, tag, and pull policyimagesection from thereloaderblock in thevalues.yamlfile, since the image details were moved to a new image sectionChart.yamlfile from1.3.0to1.3.1Motivations
We use Helmper to cache public Helm charts and related container images.
Helmper is not able to identify the image properties from this chart: https://christoffernissen.github.io/helmper/docs/parser
We thought it would be easier to submit a PR for updating this chart and make it like many other popular charts rather than updating Helmper 😇