Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix execSync in dev-apps.js #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mdqst
Copy link

@mdqst mdqst commented Nov 5, 2024

Description of the Changes

Mixing Async/Await with Synchronous Code

The function sequentialExecution is defined as an async function, but it uses execSync, which is synchronous. This creates confusion about how the flow of control works within the function. An async function is typically used when you want to perform asynchronous operations with await.

Replaced execSync with a non-blocking alternative.

Solves #INSERT_MONDAY_ID_HERE


Checklist

  • Manually tests of the main Application flows are done and passed.
  • New unit / functional tests have been added (whenever applicable).
  • Docs have been updated (whenever relevant).
  • PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is Reviewable

Replaced execSync with a non-blocking alternative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant