refactor: onlinechecker #5340
Merged
refactor: onlinechecker #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (36)
|
richard-ramos
force-pushed
the
pause/connector
branch
3 times, most recently
from
52d4d78 to
a790f39
Compare
kaichaosun
reviewed
Jun 17, 2024
vendor/github.com/waku-org/go-waku/waku/v2/peermanager/peer_connector.go
Outdated
Show resolved
Hide resolved
vendor/github.com/waku-org/go-waku/waku/v2/protocol/subscription/subscription_details.go
Outdated
Show resolved
Hide resolved
|
@kaichaosun @vpavlin @chaitanyaprem |
richard-ramos
force-pushed
the
pause/connector
branch
2 times, most recently
from
eab730d to
f03752a
Compare
richard-ramos
changed the title
|
@chaitanyaprem @kaichaosun @vpavlin |
richard-ramos
force-pushed
the
pause/connector
branch
from
f03752a to
318cfbb
Compare
kaichaosun
reviewed
Jun 26, 2024
| package onlinechecker | ||
|
|
||
| // OnlineChecker is used to determine if node has connectivity. | ||
| type OnlineChecker interface { |
There was a problem hiding this comment.
In my understanding, there could be a few status for application, Online, Offline, GoingOnline, GoingOffline, Undetermined. We may don't need all of these in Waku and Status.
Just wondering will it be better if we can have a enum for such status, and let the interface here return the current status? Something like a StatusProvider.
| if err := w.discoverAndConnectPeers(); err != nil { | ||
| w.logger.Error("failed to add wakuv2 peers", zap.Error(err)) | ||
| } | ||
| } | ||
|
|
||
| w.offline = !isOnline | ||
| w.onlineChecker.SetOnline(isOnline) |
There was a problem hiding this comment.
How about move this line in above if statement? I feel it's more straightforward. Also you may just want to use true directly.
There was a problem hiding this comment.
SetOnline should receive true or false depending on wheter the application is conencted or not. Moving it to the if would mean that IsOnline() would always return true as SetOnline would never be called with a false value to indicate the app is offline.
| @@ -1770,15 +1769,15 @@ func (w *Waku) StopDiscV5() error { | |||
| } | |||
|
|
|||
| func (w *Waku) ConnectionChanged(state connection.State) { | |||
| if !state.Offline && w.offline { | |||
| if !state.Offline && !w.onlineChecker.IsOnline() { | |||
There was a problem hiding this comment.
This will be improved if we use enum for the different status.
richard-ramos
force-pushed
the
pause/connector
branch
2 times, most recently
from
8e1e877 to
15058d2
Compare
igor-sirotin
approved these changes
Jun 27, 2024
richard-ramos
force-pushed
the
pause/connector
branch
from
15058d2 to
d4c3c58
Compare
richard-ramos
force-pushed
the
pause/connector
branch
from
d4c3c58 to
ac6fcf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if the node is offline, the peer connector will still attempt to connect to nodes reported by discv5.
This has a negative impact because the connection to the node will obviously fail, and it will increase the backoff period for the next reconnection attempt.
With this change, the peer connector will no longer attempt to connect to any peer when it's notified that the node is offline.
A similar approach is also used for the filter subscriptions, instead of having to notify each subscription that the node is online/offline, it's done in a single step with the online checker