fix(wallet)_: collectible route cleanup on navigating back from TX confirmation page #21883

smohamedjavid · 2025-01-02T21:33:21Z

Summary

This PR fixes routes not cleaned properly (Context Canceled and No Routes Found errors thrown on generating the next route) when the user navigates back from the TX confirmation screen using the device's back button/gesture.

Platforms

Android
iOS

Steps to test

Prerequisite: A wallet account with multiple collectibles

Open Status
Navigate to the Wallet Tab
Tap any collectible and enter the Send flow
Complete the flow until the TX confirmation screen
Navigate back using the device's back button or gesture
Try to complete the flow again (reaching the TX confirmation page)
Verify the Context Canceled and No Routes Found error messages are not shown

status: ready

smohamedjavid · 2025-01-02T21:34:15Z

src/status_im/contexts/wallet/collectible/utils.cljs

+   (->> ownership
+        (some #(when (= address (:address %))
+                 (:balance %)))
+        utils.number/parse-int)))


Small refactoring of collectible balance util method based on #21871 (comment)

smohamedjavid · 2025-01-02T21:40:33Z

src/status_im/contexts/wallet/send/transaction_confirmation/view.cljs

The only changes on this screen are

Removed the let var on-close as the navigate-back and clean-up events are separated

Removed the fn wrap as the functional compiler is the default

Moved the clean-up event to unmount (previously it was in a separate let var), as the event is not called when the user uses the device's back button/gesture.

smohamedjavid · 2025-01-02T21:40:40Z

src/status_im/contexts/wallet/send/transaction_confirmation/view.cljs

+                                               to-address)}
+        sign-on-keycard?          (get-in transaction-for-signing
+                                          [:signingDetails :signOnKeycard])]
+    (hot-reload/use-safe-unmount #(rf/dispatch [:wallet/clean-route-data-for-collectible-tx]))


Clean up event on unmount

smohamedjavid · 2025-01-02T21:40:43Z

src/status_im/contexts/wallet/send/transaction_confirmation/view.cljs

+      {:footer-container-padding 0
+       :header                   [quo/page-nav
+                                  {:icon-name           :i/arrow-left
+                                   :on-press            events-helper/navigate-back


Separated navigate back and clean up event (moved to unmount)

status-im-auto · 2025-01-02T21:42:28Z

Jenkins Builds

Click to see older builds (8)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`dd81fda`	#1	2025-01-02 21:42:27	~8 min	`ios`	📱`ipa` 📲
✔️	`dd81fda`	#1	2025-01-02 21:45:05	~11 min	`tests`	📄`log`
✔️	`dd81fda`	#1	2025-01-02 21:47:48	~14 min	`android`	🤖`apk` 📲
✔️	`dd81fda`	#1	2025-01-02 21:50:52	~17 min	`android-e2e`	🤖`apk` 📲

✔️	`c7dca3d`	#2	2025-01-03 08:32:56	~4 min	`tests`	📄`log`
✔️	`c7dca3d`	#2	2025-01-03 08:34:56	~6 min	`ios`	📱`ipa` 📲
✔️	`c7dca3d`	#2	2025-01-03 08:37:16	~9 min	`android`	🤖`apk` 📲
✔️	`c7dca3d`	#2	2025-01-03 08:37:26	~9 min	`android-e2e`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`3d7074b`	#3	2025-01-03 15:48:27	~4 min	`tests`	📄`log`
✔️	`3d7074b`	#3	2025-01-03 15:50:18	~6 min	`ios`	📱`ipa` 📲
✔️	`3d7074b`	#3	2025-01-03 15:50:56	~7 min	`android`	🤖`apk` 📲
✔️	`3d7074b`	#3	2025-01-03 15:51:22	~7 min	`android-e2e`	🤖`apk` 📲

❌	`a78f3c7`	#4	2025-01-07 13:02:20	~4 min	`tests`	📄`log`
✔️	`a78f3c7`	#4	2025-01-07 13:04:36	~6 min	`ios`	📱`ipa` 📲
✔️	`a78f3c7`	#4	2025-01-07 13:05:01	~7 min	`android`	🤖`apk` 📲
✔️	`a78f3c7`	#4	2025-01-07 13:07:00	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`a78f3c7`	#5	2025-01-07 13:18:42	~4 min	`tests`	📄`log`

briansztamfater

LGTM!

mohsen-ghafouri

Nice stuff

status-im-auto · 2025-01-03T09:01:16Z

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 2
Passed tests: 6

IDs of expected to fail tests: 727230,727229

Expected to fail tests (2)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Device 1: Could not reach Button by pressing system back button Balance is Invalid API Key (#err2)\|ARBTESTNET Gwei `critical/test_wallet.py:165: in test_wallet_send_asset_from_drawer sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:38: in _get_balances_before_tx sender_balance = self.network_api.get_balance(self.sender['wallet_address']) ../support/api/network_api.py:55: in get_balance return int(balance) / 1000000000000000000 invalid literal for int() with base 10: 'Invalid API Key (#err2)\|ARBTESTNET'` [[Arbiscan API is down, looking for analogue]]
2. test_wallet_send_eth, id: 727229
Device 2: Tap on found: Button Balance is Invalid API Key (#err2)\|ARBTESTNET Gwei `critical/test_wallet.py:130: in test_wallet_send_eth sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:38: in _get_balances_before_tx sender_balance = self.network_api.get_balance(self.sender['wallet_address']) ../support/api/network_api.py:55: in get_balance return int(balance) / 1000000000000000000 invalid literal for int() with base 10: 'Invalid API Key (#err2)\|ARBTESTNET'` [[Arbiscan API is down, looking for analogue]]

Passed tests (6)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

VolodLytvynenko · 2025-01-03T10:53:30Z

Hi @smohamedjavid still reproducible on IOS if the following steps are performed:

Steps:

Open multi collectible (ERC 1150)-> navigate to confirmation tx page
Open collectible (ERC 720) -> navigate to confirmation tx page
Go back using device's back button -> navigate to confirmation tx page again

Actual result:

A "Context canceled" error and a "No routes found" message are displayed.

context.mp4

Device:

iPhone 11 Pro Max, IOS 17

Logs:

logs.zip

smohamedjavid · 2025-01-03T15:43:50Z

@VolodLytvynenko - please retest 🙏 . It should be fixed now.

status-im-auto · 2025-01-03T19:35:29Z

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 0
Expected to fail tests: 2
Passed tests: 6

IDs of expected to fail tests: 727230,727229

Expected to fail tests (2)

Click to expand

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Device 1: Could not reach Button by pressing system back button Balance is Invalid API Key (#err2)\|ARBTESTNET Gwei `critical/test_wallet.py:165: in test_wallet_send_asset_from_drawer sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:38: in _get_balances_before_tx sender_balance = self.network_api.get_balance(self.sender['wallet_address']) ../support/api/network_api.py:55: in get_balance return int(balance) / 1000000000000000000 invalid literal for int() with base 10: 'Invalid API Key (#err2)\|ARBTESTNET'` [[Arbiscan API is down, looking for analogue]]
2. test_wallet_send_eth, id: 727229
Device 2: Tap on found: Button Balance is Invalid API Key (#err2)\|ARBTESTNET Gwei `critical/test_wallet.py:130: in test_wallet_send_eth sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:38: in _get_balances_before_tx sender_balance = self.network_api.get_balance(self.sender['wallet_address']) ../support/api/network_api.py:55: in get_balance return int(balance) / 1000000000000000000 invalid literal for int() with base 10: 'Invalid API Key (#err2)\|ARBTESTNET'` [[Arbiscan API is down, looking for analogue]]

Passed tests (6)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_profile_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231

2. test_wallet_balance_mainnet, id: 740490

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

VolodLytvynenko · 2025-01-07T12:55:04Z

@smohamedjavid Thank you for PR. No issues from my side. PR is ready to be merged

Signed-off-by: Mohamed Javid <[email protected]>

… back button Signed-off-by: Mohamed Javid <[email protected]>

smohamedjavid added the request-manual-qa label Jan 2, 2025

smohamedjavid self-assigned this Jan 2, 2025

smohamedjavid commented Jan 2, 2025

View reviewed changes

smohamedjavid requested review from vkjr, briansztamfater and mohsen-ghafouri January 2, 2025 21:41

smohamedjavid marked this pull request as ready for review January 2, 2025 21:41

briansztamfater approved these changes Jan 2, 2025

View reviewed changes

mohsen-ghafouri approved these changes Jan 3, 2025

View reviewed changes

smohamedjavid force-pushed the fix/route-cleanup-for-collectible-tx branch from dd81fda to c7dca3d Compare January 3, 2025 08:27

VolodLytvynenko self-assigned this Jan 3, 2025

VolodLytvynenko added the Tested - Issues label Jan 3, 2025

smohamedjavid force-pushed the fix/route-cleanup-for-collectible-tx branch from c7dca3d to 3d7074b Compare January 3, 2025 15:43

vkjr approved these changes Jan 6, 2025

View reviewed changes

VolodLytvynenko added Tested - OK and removed Tested - Issues labels Jan 7, 2025

smohamedjavid added 2 commits January 7, 2025 18:26

chore(wallet)_: Refactor collectible balance utility method

0d1edc3

Signed-off-by: Mohamed Javid <[email protected]>

fix(wallet)_: Collectible route cleanup on navigate back using device…

a78f3c7

… back button Signed-off-by: Mohamed Javid <[email protected]>

smohamedjavid force-pushed the fix/route-cleanup-for-collectible-tx branch from 3d7074b to a78f3c7 Compare January 7, 2025 12:57

smohamedjavid merged commit ba8cf8e into develop Jan 7, 2025
5 checks passed

smohamedjavid deleted the fix/route-cleanup-for-collectible-tx branch January 7, 2025 13:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(wallet)_: collectible route cleanup on navigating back from TX confirmation page #21883

fix(wallet)_: collectible route cleanup on navigating back from TX confirmation page #21883

smohamedjavid commented Jan 2, 2025

smohamedjavid Jan 2, 2025

smohamedjavid Jan 2, 2025

smohamedjavid Jan 2, 2025

smohamedjavid Jan 2, 2025

status-im-auto commented Jan 2, 2025 •

edited

Loading

briansztamfater left a comment

mohsen-ghafouri left a comment

status-im-auto commented Jan 3, 2025

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

VolodLytvynenko commented Jan 3, 2025

smohamedjavid commented Jan 3, 2025

status-im-auto commented Jan 3, 2025

Class TestWalletMultipleDevice:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

VolodLytvynenko commented Jan 7, 2025

fix(wallet)_: collectible route cleanup on navigating back from TX confirmation page #21883

fix(wallet)_: collectible route cleanup on navigating back from TX confirmation page #21883

Conversation

smohamedjavid commented Jan 2, 2025

Summary

Platforms

Steps to test

Prerequisite: A wallet account with multiple collectibles

smohamedjavid Jan 2, 2025

Choose a reason for hiding this comment

smohamedjavid Jan 2, 2025

Choose a reason for hiding this comment

smohamedjavid Jan 2, 2025

Choose a reason for hiding this comment

smohamedjavid Jan 2, 2025

Choose a reason for hiding this comment

status-im-auto commented Jan 2, 2025 • edited Loading

Jenkins Builds

briansztamfater left a comment

Choose a reason for hiding this comment

mohsen-ghafouri left a comment

Choose a reason for hiding this comment

status-im-auto commented Jan 3, 2025

75% of end-end tests have passed

Expected to fail tests (2)

Class TestWalletMultipleDevice:

Passed tests (6)

Class TestCommunityOneDeviceMerged:

Class TestWalletOneDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

VolodLytvynenko commented Jan 3, 2025

Steps:

Actual result:

Device:

Logs:

smohamedjavid commented Jan 3, 2025

status-im-auto commented Jan 3, 2025

75% of end-end tests have passed

Expected to fail tests (2)

Class TestWalletMultipleDevice:

Passed tests (6)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

VolodLytvynenko commented Jan 7, 2025

status-im-auto commented Jan 2, 2025 •

edited

Loading