Quick transaction settings #22019
Quick transaction settings #22019
Conversation
Jenkins BuildsClick to see older builds (55)
|
vkjr
force-pushed
the
quick-tx-settings-backup
branch
2 times, most recently
from
875e1c0 to
333f74f
Compare
vkjr
force-pushed
the
quick-tx-settings-backup
branch
2 times, most recently
from
22b4750 to
7a2b24c
Compare
| @@ -9,35 +9,33 @@ | |||
|
|
|||
| (defn view | |||
| [{:keys [track-text customization-color auth-button-label on-auth-success on-auth-fail | |||
| auth-button-icon-left size blur? container-style disabled? dependencies on-complete] | |||
| auth-button-icon-left size blur? container-style disabled? dependencies] | |||
There was a problem hiding this comment.
I removed on-complete because we used it to prevent the standard authorization slider from doing standard authorization, which is a bit illogical :)
So now this slider works only for standard authorization, for cases when you need to choose between keycard or standard auth there is a simple slider.
There was a problem hiding this comment.
can you explain why the changes to standard_auth were needed in this case? Asking cause I'm finishing up on the PR which also removes it, but also allows to sign e.g transaction data with standard_auth (including the keycard support). So I'm wondering what was blocking it to make sure it's also supported there?
There was a problem hiding this comment.
update: changes were discussed on a call with @clauxx and we aligned our development.
| new-path) | ||
| precision) | ||
| :eip-1559-enabled true | ||
| :tx-max-fees-per-gas (send-utils/convert-to-gwei |
There was a problem hiding this comment.
This is a new field from status-go that holds currently used gas. It need to be used for fee calculation
| new-path) | ||
| precision) | ||
| :suggested-gas-fees-for-setting | ||
| {:transaction-setting/normal (send-utils/convert-to-gwei |
There was a problem hiding this comment.
These three now used to calculate possible fees on different quick settings levels.
| :flow-id :wallet-send-flow}]]]})) | ||
|
|
||
| (rf/reg-event-fx | ||
| :wallet.send/auth-slider-completed |
There was a problem hiding this comment.
When slider moved by user we initiate sequence of building transaction and signing it
| :type :negative | ||
| :text (:message error)}]))}]}))) | ||
|
|
||
| (rf/reg-event-fx |
There was a problem hiding this comment.
This is the key refactoring.
Before if user doesnt need keycard sign, we initiated standard authorization from slider component and than were signing from this event. But when user required keycard sign, we initiated keycard authorization from this event with consecutive sign.
Now both types of authorization run from here, that simplified caller code.
| :current 31000} | ||
| :nonce {:last-transaction 21 | ||
| :current 22}}) | ||
| (assoc-in [:wallet :ui :send :confirmed-tx-setting] :transaction-setting/fast))})) |
There was a problem hiding this comment.
Saved selected user setting
| path-tx-identity (send-utils/path-identity route) | ||
| params [path-tx-identity gas-rate]] | ||
| {:db (assoc-in db [:wallet :ui :send :confirmed-tx-setting] confirmed-setting) | ||
| :json-rpc/call [{:method "wallet_setFeeMode" |
There was a problem hiding this comment.
status-go endpoint for selecting quick transaction setting
| (i18n/label :t/slide-to-send)) | ||
| :container-style {:z-index 2} | ||
| :disabled? (not transaction-for-signing) | ||
| [quo/slide-button |
There was a problem hiding this comment.
Replaced auth slider with simple slider.
| currency-symbol | ||
| fee-in-fiat)] | ||
| fee-formatted)))) | ||
| (fn [[account route currency currency-symbol prices-per-token]] |
There was a problem hiding this comment.
Removed argument from this sub, because we can extract it from db
vkjr
requested review from
briansztamfater,
clauxx,
shivekkhurana,
smohamedjavid and
alwx
vkjr
force-pushed
the
quick-tx-settings-backup
branch
from
3d8d193 to
5462f90
Compare
vkjr
force-pushed
the
quick-tx-settings-backup
branch
from
b750f3e to
c8727a3
Compare
|
@vkjr please, let us know when it is ready to testing, we need to take it ASAP as the feature is important for release and high-risk. |
fixes #21019
Summary
Quick transaction settings added. Now you can select normal/fast/urgent mode and see the estimated gas fee.
Screen.Recording.2025-02-07.at.11.39.38.mov
Review notes
Adding quick transaction settings required changes in events flow. Before this PR our app was calling status-go function
BuildTransactionsFromRouteat the moment when we navigated to transaction confirmation screen. This function stops the route updates, so the only thing we had to do is to sign the transactions.But in order to allow user to change transaction settings we need to send changes to status-go and keep getting route updates with new fees.
So the events order was changed. Now we navigate to transaction confirmation screen and still getting the routes update. But when user slides the sign button we:
BuildTransactionsFromRoutewallet.router.sign-transactionssignalAlong the way the authrization slider was refactored. Update: authorization slider changes were reverted back to not interfere with current @clauxx refactoring of authorization process
Testing notes
This PR has changed the order of events during send/bridge, so they should be tested.
Platforms
Areas that may be impacted
Functional
Steps to test
status: ready