Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Close popover menu on click (closes #301) #580

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

debnil
Copy link
Contributor

@debnil debnil commented Nov 10, 2020

This PR closes the popover menu on click, and closes #301.

@debnil
Copy link
Contributor Author

debnil commented Nov 10, 2020

@nikhilsaraf: Let's go over this PR in our pair programming session quickly. I have zero idea why this isn't working and how to fix it. What happens is that when the options toggle is clicked, every onClick function for a component of the options is selected and run - so the two windows open, and the bot is deleted. I don't understand why that would happen, so I think there's some React concept I'm missing here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1] Kelp GUI: clicking on the popover menu closes the menu
1 participant