Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: speedup go/horizon workflow tests by disabling postgres fsync #5636

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

toqueteos
Copy link

@toqueteos toqueteos commented Mar 20, 2025

What

The CI PostgreSQL shouldn't write to disk, this is accomplished by disabling fsync.

Why

The official Docker Hub postgres image doesn't expose an easy to use lever for this, bitnami/postgresql does.

This should speedup tests significantly, specially on GHA which has less than ideal I/O speeds.

Known limitations

N/A

@tamirms
Copy link
Contributor

tamirms commented Mar 24, 2025

@toqueteos the CI checks were not successful

@toqueteos
Copy link
Author

toqueteos commented Mar 25, 2025

To be honest, not the results I was expecting.

Times have gone down (on Horizon workflow) by 2~10 minutes.

But surprisingly have gone up (on Go workflow).

Go (this one is worse)

Before: https://github.com/stellar/go/actions/runs/14062641693
image

After: https://github.com/stellar/go/actions/runs/14061580978
image

Horizon (this one is better)

Before: https://github.com/stellar/go/actions/runs/14055333167
image

After: https://github.com/stellar/go/actions/runs/14061580947
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants