-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build summary to output of build command #1891
Conversation
I'd like to make a tweak to this, to hide the function list unless verbose is passed. |
@leighmcculloch you don't think showing the list every time is useful? |
@Ifropc I've changed how the command output works slightly, could you take another look? |
Hmm, maybe it is. I'm happy to wind back the verbose change. Winding it back now. |
This reverts commit d484ae9.
Reverted. Merging as is without verbose. |
@Ifropc I think it needs reapproving. |
@leighmcculloch can we hold merging it before the 22.5.0 release? I'd like to release before the EOD ideally |
Apologies, it auto merged. If necessary we can revert, but this is a small change so it's probably fine to go as is. |
What
Add build summary displaying file location, hash, and exported functions, to the
stellar contract build
command.Why
I think it could be helpful to output the wasm hash in the logs of builds.
It also outputs the exported functions because I was recently thinking more about the following issue, and pondering ways we could make it more obvious to folks when a build contains unexpected functions. This doesn't adequately solve that problem though, I wouldn't consider it a solution for that problem, so we should hold it as a why very loosely.
@fnando This was something that was more me experimenting with. I think it looks good, but I am not attached to it and can close it if you don't.