Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring binaries workflow #1956

Merged
merged 6 commits into from
Mar 18, 2025
Merged

Refactoring binaries workflow #1956

merged 6 commits into from
Mar 18, 2025

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Mar 12, 2025

What

Refactors binaries workflow moving copy-pasted part into composite action

Why

It grows larger with more artifacts we upload, it's a good idea to make it a bit more dry

Known limitations

N/A

@Ifropc Ifropc requested a review from a team March 12, 2025 23:51
@Ifropc Ifropc requested a review from a team March 17, 2025 21:53
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern, inline.

@Ifropc Ifropc enabled auto-merge (squash) March 18, 2025 22:06
@Ifropc Ifropc merged commit a562309 into main Mar 18, 2025
32 checks passed
@Ifropc Ifropc deleted the action-refactoring branch March 18, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants