github workflow v1 #119
Merged
github workflow v1 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ifropc
force-pushed
the
github-ci
branch
5 times, most recently
from
51a90dc to
2d0aa68
Compare
Ifropc
force-pushed
the
github-ci
branch
2 times, most recently
from
ea5036e to
bc87fd9
Compare
fnando
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of github workflow.
On CLI, we want to test different OSes e2e, however current limitation of our system test is that we can only effectively test linux (we are using linux base image for the test)
Migrating to GH actions will solve this issue, as we can change the runner to Mac and potentially Win to run cli tests.
As the first step, cli can adopt this workflow, with other repos to follow (if needed), though we can continue using Docker image for other purposes