RSDK-8629: mock out all tflite model services in vision service tests (…

…viamrobotics#4324)

.artifact/tree.json

@@ -52273,6 +52273,10 @@
         "hash": "93b03dc453206b6ce0cd083f96066544",
         "size": 23685
       },
+      "imagenetlabels_bkg.txt": {
+        "hash": "3fbcd001ab4d94fa66e61c033aeee134",
+        "size": 23698
+      },
       "lion.jpeg": {
         "hash": "7a24ee403e1606a0956d63dc744f24de",
         "size": 31645

services/vision/mlvision/classifier.go

@@ -132,7 +132,7 @@ func attemptToBuildClassifier(mlm mlmodel.Service,
 		}
 		confs := checkClassificationScores(probs)
 		if labels != nil && len(labels) != len(confs) {
-			return nil, errors.New("length of output expected to be length of label list (but is not)")
+			return nil, errors.Errorf("length of output (%d) expected to be length of label list (%d)", len(confs), len(labels))
 		}
 		classifications := make(classification.Classifications, 0, len(confs))
 		for i := 0; i < len(confs); i++ {

services/vision/mlvision/ml_model.go

@@ -238,6 +238,14 @@ func getLabelsFromFile(labelPath string) []string {
 		}
 		labels = append(labels, scanner.Text())
 	}
+	// if the labels come out as one line, try splitting that line by spaces or commas to extract labels
+	// Check if the labels should be comma split first and then space split.
+	if len(labels) == 1 {
+		labels = strings.Split(labels[0], ",")
+	}
+	if len(labels) == 1 {
+		labels = strings.Split(labels[0], " ")
+	}
 	return labels
 }
 
@@ -255,18 +263,9 @@ func getLabelsFromMetadata(md mlmodel.MLMetadata, labelPath string) []string {
 			return nil
 		}
 		labels := getLabelsFromFile(labelPath)
-		if len(labels) == 0 {
-			return nil
-		}
-		// if the labels come out as one line, try splitting that line by spaces or commas to extract labels
-		// Check if the labels should be comma split first and then space split.
-		if len(labels) == 1 {
-			labels = strings.Split(labels[0], ",")
-		}
-		if len(labels) == 1 {
-			labels = strings.Split(labels[0], " ")
+		if len(labels) != 0 {
+			return labels
 		}
-		return labels
 	}
 	return nil
 }