Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument Reflex processing in development and log a summary #686

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Mar 23, 2024

  1. Configuration menu
    Copy the full SHA
    83218b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c704d41 View commit details
    Browse the repository at this point in the history
  3. standardrb --fix

    Matt-Yorkley committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    2924ee0 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2024

  1. Improve summary of allocations and time spent rendering

    It turns out emitted `render` events from Rails overlap cumulatively if you render a partial in a partial, and there's no nice way to differentiate parent partials from children, so the duration and allocations counts can be way off when the totals from the events are summed. View time can end up being twice as much as the total time, which is obviously impossible. Rails cheats a bit for it's rendering totals by taking the whole page template, but that doesn't work for SR, so allocations and rendering time have to be calculated a bit differently.
    Matt-Yorkley committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    876bf7c View commit details
    Browse the repository at this point in the history