Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ManagersProvidingService link from service root #382

Closed
wants to merge 1 commit into from

Conversation

iamsli
Copy link
Contributor

@iamsli iamsli commented Nov 11, 2024

I'd like to be able to just see the uri of the managers link from service root without calling the url.

@stmcginnis
Copy link
Owner

We've generally tried not to expose the links directly throughout gofish. Can you explain why you would need something like this in the library? Especially from the service root, this seems easy enough to get with a couple of http get requests.

@iamsli
Copy link
Contributor Author

iamsli commented Nov 12, 2024

I want to be able to know what the device is from the service root independent of other properties. Definitely can get this via some http gets but wanted to make the code simpler 😄

@iamsli
Copy link
Contributor Author

iamsli commented Nov 12, 2024

@stmcginnis feel free to close this PR if it goes against the integrity of gofish

@stmcginnis
Copy link
Owner

Sorry, I know it's a pretty trivial thing, but I'd like to try to avoid this unless there's a strong need.

I think some vendors have OEM extensions to the ServiceRoot. It's a little more clunky, but I could see we might need to have a RawData property like some of the other objects so an OEM version of the ServiceRoot could be instantiated. Maybe you could add that and pull out the link from there?

@iamsli
Copy link
Contributor Author

iamsli commented Nov 12, 2024

yes definitely there are workarounds. it sounds like this isn't a good fit for gofish, closing. thank you for taking a look!

@iamsli iamsli closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants