Override WithTooltips default role of 'button' #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelArestad
approved these changes
Jul 13, 2023
andrewortwein
deleted the
andrew/ap-3209-the-sign-inup-form-and-likely-other-parts-of-the-site-does
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Inputcomponent contains anErrorTooltipwrapper (an instance ofWithTooltip). That wrapper, by default, has an aria role of 'button'. It's very strange for an input field to have a button role and it is causing problems with iOS VoiceControl, where selecting that field does not show the on-screen keyboard.With this change, the role will be overriden to 'none', allowing the keyboard to show.