Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF: Add run and play function in csf factory #30648

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 24, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 79.6 MB 79.6 MB 0 B -4.27 0%
initSize 79.6 MB 79.6 MB 0 B -4.27 0%
diffSize 97 B 97 B 0 B - 0%
buildSize 7.29 MB 7.29 MB 616 B -2.24 0%
buildSbAddonsSize 1.9 MB 1.9 MB 501 B Infinity 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.88 MB 1.88 MB 0 B 1.22 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.97 MB 3.97 MB 501 B 1.44 0%
buildPreviewSize 3.32 MB 3.32 MB 115 B -2.37 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 10.2s 7.6s -2s -635ms -0.75 -34.6%
generateTime 22.6s 19.5s -3s -102ms -0.35 -15.9%
initTime 5.4s 4.5s -943ms -0.7 -20.9%
buildTime 11s 8s -3s -45ms -1.62 🔰-37.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.5s 5.5s -29ms 0 -0.5%
devManagerResponsive 5.3s 5.1s -191ms -0.07 -3.7%
devManagerHeaderVisible 681ms 859ms 178ms 1.34 🔺20.7%
devManagerIndexVisible 691ms 872ms 181ms 1.05 20.8%
devStoryVisibleUncached 1.1s 1.8s 691ms 0.22 36.7%
devStoryVisible 758ms 940ms 182ms 1.9 🔺19.4%
devAutodocsVisible 674ms 742ms 68ms -0.23 9.2%
devMDXVisible 622ms 795ms 173ms 0.97 21.8%
buildManagerHeaderVisible 1.1s 988ms -205ms 1.01 -20.7%
buildManagerIndexVisible 1.2s 995ms -281ms 0.76 -28.2%
buildStoryVisible 1.1s 942ms -232ms 0.94 -24.6%
buildAutodocsVisible 1s 722ms -354ms 0.65 -49%
buildMDXVisible 683ms 547ms -136ms -0.59 -24.9%

Copy link

nx-cloud bot commented Feb 24, 2025

View your CI Pipeline Execution ↗ for commit c7c4310.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 2m View ↗

☁️ Nx Cloud last updated this comment at 2025-02-25 12:19:07 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants