Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valentin/test package consolidation #30715

Closed
wants to merge 6 commits into from

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Feb 28, 2025
@valentinpalkovic valentinpalkovic added ci:normal maintenance User-facing maintenance tasks BREAKING CHANGE and removed maintenance User-facing maintenance tasks labels Feb 28, 2025
Copy link
Contributor

Fails
🚫 PR is marked with "BREAKING CHANGE" label.
🚫 PR title must be in the format of "Area: Summary", With both Area and Summary starting with a capital letter Good examples: - "Docs: Describe Canvas Doc Block" - "Svelte: Support Svelte v4" Bad examples: - "add new api docs" - "fix: Svelte 4 support" - "Vue: improve docs"

Generated by 🚫 dangerJS against e0c07db

@valentinpalkovic valentinpalkovic force-pushed the valentin/test-package-consolidation branch 3 times, most recently from 2c576f4 to e7022b6 Compare February 28, 2025 12:56
Copy link

nx-cloud bot commented Feb 28, 2025

View your CI Pipeline Execution ↗ for commit 9e110ae.

Command Status Duration Result
nx run-many -t build -c production --parallel=3 ❌ Failed 3m 30s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-28 19:12:09 UTC

@valentinpalkovic valentinpalkovic force-pushed the valentin/test-package-consolidation branch 2 times, most recently from 824c7b2 to e067f0c Compare February 28, 2025 13:21
@valentinpalkovic valentinpalkovic force-pushed the valentin/test-package-consolidation branch from e067f0c to 2384943 Compare February 28, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant