Test: Bump version of @testing-library/user-event #30758
+12
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 0c960a5.
☁️ Nx Cloud last updated this comment at |
kasperpeulen
changed the title
kasperpeulen
added
ci:daily
kasperpeulen
approved these changes
Mar 6, 2025
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
kasperpeulen
added
the
patch:yes
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 99 | 99 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 43.24 MB | 43.25 MB | 🚨 +11 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 388 | 388 | 0 |
| Self size | 284 KB | 284 KB | 0 B |
| Dependency size | 93.38 MB | 93.39 MB | 🚨 +11 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 309 | 309 | 0 |
| Self size | 614 KB | 614 KB | 0 B |
| Dependency size | 74.99 MB | 75.00 MB | 🚨 +11 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
kasperpeulen
added
ci:merged
kasperpeulen
added
ci:normal
and removed
ci:merged
|
@kasperpeulen I am not sure if I am reading the output correctly but it seems there are some unexpected failures in svelte tests: |
… sjwilczy/bumpTLUserEvent
… sjwilczy/bumpTLUserEvent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The newer version of @testing-library/user-event contains a bunch of fixes:
Particularly interesting one for my team is testing-library/user-event#1049, which will allow us to remove a patch file we had for @storybook/test, which kept the proper keyboard navigation for radio groups.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
I opened the default template after
yarn startbut let me know if you think I should add the radio group scenario and if so, where would be a good placeTODO
Documentation
Not needed, just a version bump
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updates @testing-library/user-event from 14.5.2 to 14.6.1 across multiple package.json files to incorporate bug fixes, particularly for keyboard navigation in radio groups.
code/lib/test/package.jsonwill enable removal of an existing patch file for radio group keyboard navigationcode/package.jsonandscripts/package.jsonto maintain consistencyscripts/utils/yarn.tsto update package resolutions to 14.6.1💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!