Addon Accessibility: Various improvements #30774

ghengeveld · 2025-03-07T16:58:19Z

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

stories
unit tests
integration tests
end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name	before	after	diff	z	%
createSize	0 B	0 B	0 B	-	-
generateSize	79.9 MB	79.9 MB	0 B	0.32	0%
initSize	79.9 MB	79.9 MB	0 B	0.32	0%
diffSize	97 B	97 B	0 B	-	0%
buildSize	7.47 MB	7.45 MB	-25.9 kB	-1.04	-0.3%
buildSbAddonsSize	1.98 MB	1.9 MB	-81 kB	-1.1	-4.3%
buildSbCommonSize	195 kB	195 kB	0 B	-	0%
buildSbManagerSize	1.88 MB	1.88 MB	0 B	-	0%
buildSbPreviewSize	0 B	0 B	0 B	-	-
buildStaticSize	0 B	0 B	0 B	-	-
buildPrebuildSize	4.06 MB	3.97 MB	-81 kB	-1.1	-2%
buildPreviewSize	3.42 MB	3.47 MB	55.1 kB	-0.66	1.6%
testBuildSize	0 B	0 B	0 B	-	-
testBuildSbAddonsSize	0 B	0 B	0 B	-	-
testBuildSbCommonSize	0 B	0 B	0 B	-	-
testBuildSbManagerSize	0 B	0 B	0 B	-	-
testBuildSbPreviewSize	0 B	0 B	0 B	-	-
testBuildStaticSize	0 B	0 B	0 B	-	-
testBuildPrebuildSize	0 B	0 B	0 B	-	-
testBuildPreviewSize	0 B	0 B	0 B	-	-

name	before	after	diff	z	%
createTime	11.5s	28.3s	16.7s	1.53	🔺59.2%
generateTime	20.2s	22s	1.7s	1.81	🔺8%
initTime	4.9s	4.9s	-43ms	0.52	-0.9%
buildTime	9.1s	9.6s	442ms	0.3	4.6%
testBuildTime	0ms	0ms	0ms	-	-
devPreviewResponsive	4.6s	5.5s	886ms	0.51	16%
devManagerResponsive	4.4s	5.2s	821ms	0.52	15.6%
devManagerHeaderVisible	782ms	918ms	136ms	0.65	14.8%
devManagerIndexVisible	793ms	1s	214ms	0.98	21.3%
devStoryVisibleUncached	2.7s	2.5s	-131ms	-0.1	-5%
devStoryVisible	1.2s	1.2s	35ms	-0.18	2.8%
devAutodocsVisible	1.1s	1s	-39ms	-0.42	-3.6%
devMDXVisible	1.1s	1s	-70ms	-0.78	-6.6%
buildManagerHeaderVisible	880ms	802ms	-78ms	-0.55	-9.7%
buildManagerIndexVisible	885ms	825ms	-60ms	-0.47	-7.3%
buildStoryVisible	869ms	791ms	-78ms	-0.56	-9.9%
buildAutodocsVisible	618ms	753ms	135ms	-0.32	17.9%
buildMDXVisible	666ms	788ms	122ms	0.2	15.5%

…tton

nx-cloud · 2025-03-07T17:00:08Z

View your CI Pipeline Execution ↗ for commit f2d8eb0.

Command	Status	Duration	Result
`nx run-many -t build --parallel=3`	✅ Succeeded	1m 59s	View ↗

☁️ Nx Cloud last updated this comment at 2025-03-07 17:03:16 UTC

storybook-pr-benchmarking · 2025-03-07T17:06:26Z

Package Benchmarks

^{Commit: f2d8eb0, ran on 7 March 2025 at 17:06:23 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/addon-a11y`

	Before	After	Difference
Dependency count	3	54	🚨 +51 🚨
Self size	445 KB	443 KB	🎉 -2 KB 🎉
Dependency size	2.81 MB	12.47 MB	🚨 +9.66 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-interactions`

	Before	After	Difference
Dependency count	5	54	🚨 +49 🚨
Self size	129 KB	129 KB	🚨 +70 B 🚨
Dependency size	3.11 MB	12.49 MB	🚨 +9.39 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/addon-test`

	Before	After	Difference
Dependency count	9	58	🚨 +49 🚨
Self size	844 KB	844 KB	🚨 +52 B 🚨
Dependency size	4.56 MB	13.95 MB	🚨 +9.39 MB 🚨
Bundle Size Analyzer	Link	Link

`storybook`

	Before	After	Difference
Dependency count	98	51	🎉 -47 🎉
Self size	21.54 MB	19.40 MB	🎉 -2.15 MB 🎉
Dependency size	21.69 MB	14.26 MB	🎉 -7.43 MB 🎉
Bundle Size Analyzer	Link	Link

`@storybook/experimental-nextjs-vite`

	Before	After	Difference
Dependency count	141	180	🚨 +39 🚨
Self size	215 KB	236 KB	🚨 +21 KB 🚨
Dependency size	39.37 MB	49.14 MB	🚨 +9.78 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/nextjs`

	Before	After	Difference
Dependency count	540	584	🚨 +44 🚨
Self size	218 KB	475 KB	🚨 +257 KB 🚨
Dependency size	58.82 MB	83.39 MB	🚨 +24.58 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-native-web-vite`

	Before	After	Difference
Dependency count	172	172	0
Self size	35 KB	45 KB	🚨 +10 KB 🚨
Dependency size	24.30 MB	24.31 MB	🚨 +9 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-vite`

	Before	After	Difference
Dependency count	122	124	🚨 +2 🚨
Self size	15 KB	15 KB	🚨 +127 B 🚨
Dependency size	20.46 MB	20.49 MB	🚨 +21 KB 🚨
Bundle Size Analyzer	Link	Link

`sb`

	Before	After	Difference
Dependency count	99	52	🎉 -47 🎉
Self size	1 KB	1 KB	0 B
Dependency size	43.24 MB	33.66 MB	🎉 -9.58 MB 🎉
Bundle Size Analyzer	Link	Link

`@storybook/cli`

	Before	After	Difference
Dependency count	388	356	🎉 -32 🎉
Self size	282 KB	284 KB	🚨 +2 KB 🚨
Dependency size	93.24 MB	84.16 MB	🎉 -9.08 MB 🎉
Bundle Size Analyzer	Link	Link

`@storybook/codemod`

	Before	After	Difference
Dependency count	309	274	🎉 -35 🎉
Self size	614 KB	617 KB	🚨 +3 KB 🚨
Dependency size	74.84 MB	65.75 MB	🎉 -9.10 MB 🎉
Bundle Size Analyzer	Link	Link

`@storybook/test`

	Before	After	Difference
Dependency count	48	51	🚨 +3 🚨
Self size	1.82 MB	1.82 MB	🚨 +24 B 🚨
Dependency size	7.42 MB	7.85 MB	🚨 +425 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/html`

	Before	After	Difference
Dependency count	2	2	0
Self size	38 KB	47 KB	🚨 +9 KB 🚨
Dependency size	32 KB	32 KB	0 B
Bundle Size Analyzer	Link	Link

`@storybook/vue3`

	Before	After	Difference
Dependency count	13	13	0
Self size	78 KB	87 KB	🚨 +9 KB 🚨
Dependency size	6.13 MB	6.13 MB	0 B
Bundle Size Analyzer	Link	Link

`@storybook/web-components`

	Before	After	Difference
Dependency count	3	3	0
Self size	55 KB	62 KB	🚨 +7 KB 🚨
Dependency size	47 KB	47 KB	0 B
Bundle Size Analyzer	Link	Link

ghengeveld added 5 commits March 4, 2025 09:51

Include main a11y stories in storybook-ui and set fullscreen layout

1776ed5

Fix dark mode rendering for a11y panel stories

0888979

Update tab bar styling

6401973

Update A11y addon tab bar with new highlighting behavior and rerun bu…

5a2b90d

…tton

Update accordion styling

f2d8eb0

ghengeveld added feature request ci:normal labels Mar 7, 2025

ghengeveld self-assigned this Mar 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addon Accessibility: Various improvements #30774

Addon Accessibility: Various improvements #30774

ghengeveld commented Mar 7, 2025 •

edited by storybook-pr-benchmarking bot

Loading

nx-cloud bot commented Mar 7, 2025 •

edited

Loading

storybook-pr-benchmarking bot commented Mar 7, 2025

Addon Accessibility: Various improvements #30774

Are you sure you want to change the base?

Addon Accessibility: Various improvements #30774

Conversation

ghengeveld commented Mar 7, 2025 • edited by storybook-pr-benchmarking bot Loading

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

Documentation

Checklist for Maintainers

🦋 Canary release

nx-cloud bot commented Mar 7, 2025 • edited Loading

storybook-pr-benchmarking bot commented Mar 7, 2025

Package Benchmarks

@storybook/addon-a11y

@storybook/addon-interactions

@storybook/addon-test

storybook

@storybook/experimental-nextjs-vite

@storybook/nextjs

@storybook/react-native-web-vite

@storybook/react-vite

sb

@storybook/cli

@storybook/codemod

@storybook/test

@storybook/html

@storybook/vue3

@storybook/web-components

ghengeveld commented Mar 7, 2025 •

edited by storybook-pr-benchmarking bot

Loading

nx-cloud bot commented Mar 7, 2025 •

edited

Loading

`@storybook/addon-a11y`

`@storybook/addon-interactions`

`@storybook/addon-test`

`storybook`

`@storybook/experimental-nextjs-vite`

`@storybook/nextjs`

`@storybook/react-native-web-vite`

`@storybook/react-vite`

`sb`

`@storybook/cli`

`@storybook/codemod`

`@storybook/test`

`@storybook/html`

`@storybook/vue3`

`@storybook/web-components`