Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Remote #1398

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Conversation

poldi171254
Copy link

The one thing I'm missing in Strawberry is a Remote capability.
I have over 1000 CD, collected over many years, and as we all know, not every song on every CD is great.
In Clementine, if I didn't like something I heard while I was away from the PC/Music System, I could just go Next.

I have added a basic Remote capability to Strawberry

  • The functionality is very basic and not like Clementine (no downloads, playlist changes, etc); all you can do is Play, Pause, Next Previous, Stop, Finish
  • Both Strawberry and the Remote were built in Qt Creator; not sure if command line works.
  • I've created a Remote Client for testing which can be built from [email protected]:poldi171254/StrawberryRemote.git
  • This is a first draft and will obviously need more work

Thanks,
Leo

@poldi171254
Copy link
Author

Just realized I forgot instruction on how to use/enable this.
There is a new settings item, similar to Clementine, that allows the config for the remote

@poldi171254
Copy link
Author

I'd appreciate if somebody could explain why the Ubuntu build fails

@jonaski
Copy link
Member

jonaski commented Apr 20, 2024

I'd appreciate if somebody could explain why the Ubuntu build fails

QAbstractSocket::errorOccurred was introduced in Qt 5.15, while Ubuntu Focal has Qt 5.12.

For now we still support building with Qt 5, so strawberry can still be supported on LTS distros, but we should probably drop it in not to long future. Qt 5 is already in closed branches for commercial customers and it's hard to know what the "5.12" and "5.15" that distros ship actually is anymore since KDE actually do their own thing with it.

@poldi171254
Copy link
Author

Ubuntu 24.04 LTS release is planned for April 25, so I guesss we can check this then

@CAPSLOCK2000
Copy link

I got it to compile and run on Debian after manually replacing the contents of 3rdparty/kdsingleapplication with a complete copy of https://github.com/KDAB/KDSingleApplication. The copy of KDSingleApplication in Debian is to old an Ubuntu probably has the same problem.

However I cannot find the github.com:poldi171254/StrawberryRemote.git repository so I can't really test it.

I tried to use it with code written for clementine remote (without any recompling for Strawberry). It does connect but is unable to parse the messages from the server, probably due to incompatible protobuf message formats. More or less as expected.

FWIW, the code compiled cleanly and Strawberry works fine with the remote code enabled.

@poldi171254
Copy link
Author

Thanks for your feedback. I didn't worry about the KDSingleApplication while the remote code was still in development.
The code for the remote is
for ssh
[email protected]:poldi171254/StrawberryRemote.git
for https
https://github.com/poldi171254/StrawberryRemote.git

@CAPSLOCK2000
Copy link

CAPSLOCK2000 commented May 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants